Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index deb63130a8b2b82f52b7068e78fb295396571aeb..cb328d688352e5ad1023aa2e6e2cb1d6c64c1ba2 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -215,7 +215,6 @@
#include "components/arc/arc_bridge_service_impl.h"
#include "components/arc/arc_service_manager.h"
#include "components/arc/test/fake_arc_bridge_bootstrap.h"
-#include "components/arc/test/fake_arc_bridge_instance.h"
#include "components/signin/core/account_id/account_id.h"
#include "components/user_manager/user_manager.h"
#include "ui/keyboard/keyboard_util.h"
@@ -4131,11 +4130,11 @@ class ArcPolicyTest : public PolicyTest {
std::unique_ptr<chromeos::SessionManagerClient>(
fake_session_manager_client_));
- fake_arc_bridge_instance_.reset(new arc::FakeArcBridgeInstance);
- arc::ArcServiceManager::SetArcBridgeServiceForTesting(
- base::WrapUnique(new arc::ArcBridgeServiceImpl(
- base::WrapUnique(new arc::FakeArcBridgeBootstrap(
- fake_arc_bridge_instance_.get())))));
+ std::unique_ptr<arc::ArcBridgeServiceImpl> service(
+ new arc::ArcBridgeServiceImpl);
+ service->SetArcBridgeBootstrapFactoryForTesting(
+ base::Bind(arc::FakeArcBridgeBootstrap::Create));
+ arc::ArcServiceManager::SetArcBridgeServiceForTesting(std::move(service));
}
void SetUpCommandLine(base::CommandLine* command_line) override {
@@ -4146,7 +4145,6 @@ class ArcPolicyTest : public PolicyTest {
private:
chromeos::FakeSessionManagerClient *fake_session_manager_client_;
- std::unique_ptr<arc::FakeArcBridgeInstance> fake_arc_bridge_instance_;
DISALLOW_COPY_AND_ASSIGN(ArcPolicyTest);
};

Powered by Google App Engine
This is Rietveld 408576698