Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: components/arc/arc_service_manager.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ArcBridgeBootstrap race issues. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_service_manager.h" 5 #include "components/arc/arc_service_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "components/arc/arc_bridge_bootstrap.h"
13 #include "components/arc/arc_bridge_service.h" 12 #include "components/arc/arc_bridge_service.h"
14 #include "components/arc/arc_bridge_service_impl.h" 13 #include "components/arc/arc_bridge_service_impl.h"
15 #include "components/arc/audio/arc_audio_bridge.h" 14 #include "components/arc/audio/arc_audio_bridge.h"
16 #include "components/arc/bluetooth/arc_bluetooth_bridge.h" 15 #include "components/arc/bluetooth/arc_bluetooth_bridge.h"
17 #include "components/arc/clipboard/arc_clipboard_bridge.h" 16 #include "components/arc/clipboard/arc_clipboard_bridge.h"
18 #include "components/arc/crash_collector/arc_crash_collector_bridge.h" 17 #include "components/arc/crash_collector/arc_crash_collector_bridge.h"
19 #include "components/arc/ime/arc_ime_service.h" 18 #include "components/arc/ime/arc_ime_service.h"
20 #include "components/arc/intent_helper/activity_icon_loader.h" 19 #include "components/arc/intent_helper/activity_icon_loader.h"
21 #include "components/arc/metrics/arc_metrics_service.h" 20 #include "components/arc/metrics/arc_metrics_service.h"
22 #include "components/arc/net/arc_net_host_impl.h" 21 #include "components/arc/net/arc_net_host_impl.h"
(...skipping 21 matching lines...) Expand all
44 : blocking_task_runner_(blocking_task_runner), 43 : blocking_task_runner_(blocking_task_runner),
45 icon_loader_(new ActivityIconLoader), 44 icon_loader_(new ActivityIconLoader),
46 activity_resolver_(new LocalActivityResolver) { 45 activity_resolver_(new LocalActivityResolver) {
47 DCHECK(!g_arc_service_manager); 46 DCHECK(!g_arc_service_manager);
48 g_arc_service_manager = this; 47 g_arc_service_manager = this;
49 48
50 if (g_arc_bridge_service_for_testing) { 49 if (g_arc_bridge_service_for_testing) {
51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing); 50 arc_bridge_service_.reset(g_arc_bridge_service_for_testing);
52 g_arc_bridge_service_for_testing = nullptr; 51 g_arc_bridge_service_for_testing = nullptr;
53 } else { 52 } else {
54 arc_bridge_service_.reset(new ArcBridgeServiceImpl( 53 arc_bridge_service_.reset(new ArcBridgeServiceImpl);
55 ArcBridgeBootstrap::Create()));
56 } 54 }
57 55
58 AddService(base::WrapUnique(new ArcAudioBridge(arc_bridge_service()))); 56 AddService(base::WrapUnique(new ArcAudioBridge(arc_bridge_service())));
59 AddService(base::WrapUnique(new ArcBluetoothBridge(arc_bridge_service()))); 57 AddService(base::WrapUnique(new ArcBluetoothBridge(arc_bridge_service())));
60 AddService(base::WrapUnique(new ArcClipboardBridge(arc_bridge_service()))); 58 AddService(base::WrapUnique(new ArcClipboardBridge(arc_bridge_service())));
61 AddService( 59 AddService(
62 base::WrapUnique(new ArcCrashCollectorBridge(arc_bridge_service()))); 60 base::WrapUnique(new ArcCrashCollectorBridge(arc_bridge_service())));
63 AddService(base::WrapUnique(new ArcImeService(arc_bridge_service()))); 61 AddService(base::WrapUnique(new ArcImeService(arc_bridge_service())));
64 AddService(base::WrapUnique(new ArcMetricsService(arc_bridge_service()))); 62 AddService(base::WrapUnique(new ArcMetricsService(arc_bridge_service())));
65 AddService(base::WrapUnique(new ArcNetHostImpl(arc_bridge_service()))); 63 AddService(base::WrapUnique(new ArcNetHostImpl(arc_bridge_service())));
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // static 115 // static
118 void ArcServiceManager::SetArcBridgeServiceForTesting( 116 void ArcServiceManager::SetArcBridgeServiceForTesting(
119 std::unique_ptr<ArcBridgeService> arc_bridge_service) { 117 std::unique_ptr<ArcBridgeService> arc_bridge_service) {
120 if (g_arc_bridge_service_for_testing) { 118 if (g_arc_bridge_service_for_testing) {
121 delete g_arc_bridge_service_for_testing; 119 delete g_arc_bridge_service_for_testing;
122 } 120 }
123 g_arc_bridge_service_for_testing = arc_bridge_service.release(); 121 g_arc_bridge_service_for_testing = arc_bridge_service.release();
124 } 122 }
125 123
126 } // namespace arc 124 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698