Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: components/arc/arc_service_manager.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_service_manager.h" 5 #include "components/arc/arc_service_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "components/arc/arc_bridge_bootstrap.h"
13 #include "components/arc/arc_bridge_service.h" 12 #include "components/arc/arc_bridge_service.h"
14 #include "components/arc/arc_bridge_service_impl.h" 13 #include "components/arc/arc_bridge_service_impl.h"
15 #include "components/arc/audio/arc_audio_bridge.h" 14 #include "components/arc/audio/arc_audio_bridge.h"
16 #include "components/arc/bluetooth/arc_bluetooth_bridge.h" 15 #include "components/arc/bluetooth/arc_bluetooth_bridge.h"
17 #include "components/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h" 16 #include "components/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h"
18 #include "components/arc/clipboard/arc_clipboard_bridge.h" 17 #include "components/arc/clipboard/arc_clipboard_bridge.h"
19 #include "components/arc/crash_collector/arc_crash_collector_bridge.h" 18 #include "components/arc/crash_collector/arc_crash_collector_bridge.h"
20 #include "components/arc/ime/arc_ime_service.h" 19 #include "components/arc/ime/arc_ime_service.h"
21 #include "components/arc/intent_helper/activity_icon_loader.h" 20 #include "components/arc/intent_helper/activity_icon_loader.h"
22 #include "components/arc/metrics/arc_metrics_service.h" 21 #include "components/arc/metrics/arc_metrics_service.h"
(...skipping 22 matching lines...) Expand all
45 : blocking_task_runner_(blocking_task_runner), 44 : blocking_task_runner_(blocking_task_runner),
46 icon_loader_(new ActivityIconLoader), 45 icon_loader_(new ActivityIconLoader),
47 activity_resolver_(new LocalActivityResolver) { 46 activity_resolver_(new LocalActivityResolver) {
48 DCHECK(!g_arc_service_manager); 47 DCHECK(!g_arc_service_manager);
49 g_arc_service_manager = this; 48 g_arc_service_manager = this;
50 49
51 if (g_arc_bridge_service_for_testing) { 50 if (g_arc_bridge_service_for_testing) {
52 arc_bridge_service_.reset(g_arc_bridge_service_for_testing); 51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing);
53 g_arc_bridge_service_for_testing = nullptr; 52 g_arc_bridge_service_for_testing = nullptr;
54 } else { 53 } else {
55 arc_bridge_service_.reset(new ArcBridgeServiceImpl( 54 arc_bridge_service_.reset(new ArcBridgeServiceImpl());
56 ArcBridgeBootstrap::Create()));
57 } 55 }
58 56
59 AddService(base::MakeUnique<ArcAudioBridge>(arc_bridge_service())); 57 AddService(base::MakeUnique<ArcAudioBridge>(arc_bridge_service()));
60 AddService(base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service())); 58 AddService(base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service()));
61 AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>(arc_bridge_service())); 59 AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>(arc_bridge_service()));
62 AddService(base::MakeUnique<ArcClipboardBridge>(arc_bridge_service())); 60 AddService(base::MakeUnique<ArcClipboardBridge>(arc_bridge_service()));
63 AddService(base::MakeUnique<ArcCrashCollectorBridge>(arc_bridge_service(), 61 AddService(base::MakeUnique<ArcCrashCollectorBridge>(arc_bridge_service(),
64 blocking_task_runner_)); 62 blocking_task_runner_));
65 AddService(base::MakeUnique<ArcImeService>(arc_bridge_service())); 63 AddService(base::MakeUnique<ArcImeService>(arc_bridge_service()));
66 AddService(base::MakeUnique<ArcMetricsService>(arc_bridge_service())); 64 AddService(base::MakeUnique<ArcMetricsService>(arc_bridge_service()));
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // static 112 // static
115 void ArcServiceManager::SetArcBridgeServiceForTesting( 113 void ArcServiceManager::SetArcBridgeServiceForTesting(
116 std::unique_ptr<ArcBridgeService> arc_bridge_service) { 114 std::unique_ptr<ArcBridgeService> arc_bridge_service) {
117 if (g_arc_bridge_service_for_testing) { 115 if (g_arc_bridge_service_for_testing) {
118 delete g_arc_bridge_service_for_testing; 116 delete g_arc_bridge_service_for_testing;
119 } 117 }
120 g_arc_bridge_service_for_testing = arc_bridge_service.release(); 118 g_arc_bridge_service_for_testing = arc_bridge_service.release();
121 } 119 }
122 120
123 } // namespace arc 121 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/arc_bridge_service_unittest.cc ('k') | components/arc/test/fake_arc_bridge_bootstrap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698