Fix ArcBridgeBootstrap race issues.

components/arc/test/fake_arc_bridge_bootstrap.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_
 #define COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_
 
 #include "base/macros.h"
 #include "components/arc/arc_bridge_bootstrap.h"
 #include "components/arc/test/fake_arc_bridge_instance.h"
 
 namespace arc {
 
 // A fake ArcBridgeBootstrap that creates a local connection.
-class FakeArcBridgeBootstrap : public ArcBridgeBootstrap,
-                               public FakeArcBridgeInstance::Delegate {
+class FakeArcBridgeBootstrap : public ArcBridgeBootstrap {
  public:
-  explicit FakeArcBridgeBootstrap(FakeArcBridgeInstance* instance);
-  ~FakeArcBridgeBootstrap() override = default;
+  FakeArcBridgeBootstrap();
+  ~FakeArcBridgeBootstrap() override;
 
   // ArcBridgeBootstrap:
   void Start() override;
   void Stop() override;
 
+  // To emulate unexpected stop, such as crash.
+  void StopWithReason(ArcBridgeService::StopReason reason);
+
+  // Follows control Start() behavior for testing various situations.

[Luis Héctor Chávez, 2016/09/07 23:38:32]

nit: s/Follows/The following/

[hidehiko, 2016/09/08 16:53:41]

Done.

+
+  // Enables/disables boot failure emulation, in which OnStopped(reason) will
+  // be called when Start() is called.
+  void EnableBootFailureEmulation(ArcBridgeService::StopReason reason);
+
+  // Emulate Start() is suspended at some phase, before OnReady() is invoked.
+  void SuspendBoot();
+
  private:
-  // FakeArcBridgeInstance::Delegate:
-  void OnStopped(ArcBridgeService::StopReason reason) override;
+  bool boot_failure_emulation_enabled_ = false;
+  ArcBridgeService::StopReason boot_failure_reason_;
+  FakeArcBridgeInstance instance_;
 
-  // Owned by the caller.
-  FakeArcBridgeInstance* instance_;
+  bool boot_suspended_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(FakeArcBridgeBootstrap);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_