Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/arc/test/fake_arc_bridge_bootstrap.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/test/fake_arc_bridge_bootstrap.h" 5 #include "components/arc/test/fake_arc_bridge_bootstrap.h"
6 6
7 #include <utility>
8
9 #include "base/logging.h" 7 #include "base/logging.h"
10 #include "components/arc/common/arc_bridge.mojom.h"
11 #include "components/arc/test/fake_arc_bridge_instance.h"
12 #include "mojo/public/cpp/bindings/interface_request.h"
13 8
14 namespace arc { 9 namespace arc {
15 10
16 FakeArcBridgeBootstrap::FakeArcBridgeBootstrap(FakeArcBridgeInstance* instance) 11 FakeArcBridgeBootstrap::FakeArcBridgeBootstrap() = default;
17 : instance_(instance) { 12
18 instance_->set_delegate(this); 13 FakeArcBridgeBootstrap::~FakeArcBridgeBootstrap() = default;
19 }
20 14
21 void FakeArcBridgeBootstrap::Start() { 15 void FakeArcBridgeBootstrap::Start() {
22 DCHECK(delegate_); 16 DCHECK(delegate_);
23 mojom::ArcBridgeInstancePtr instance; 17 if (boot_failure_emulation_enabled_) {
24 instance_->Bind(mojo::GetProxy(&instance)); 18 delegate_->OnStopped(boot_failure_reason_);
25 delegate_->OnConnectionEstablished(std::move(instance)); 19 } else if (!boot_suspended_) {
20 mojom::ArcBridgeInstancePtr instance_ptr;
21 instance_.Bind(mojo::GetProxy(&instance_ptr));
22 delegate_->OnConnectionEstablished(std::move(instance_ptr));
23 }
26 } 24 }
27 25
28 void FakeArcBridgeBootstrap::Stop() { 26 void FakeArcBridgeBootstrap::Stop() {
29 DCHECK(delegate_); 27 StopWithReason(ArcBridgeService::StopReason::SHUTDOWN);
30 instance_->Unbind();
31 delegate_->OnStopped(ArcBridgeService::StopReason::SHUTDOWN);
32 } 28 }
33 29
34 void FakeArcBridgeBootstrap::OnStopped(ArcBridgeService::StopReason reason) { 30 void FakeArcBridgeBootstrap::StopWithReason(
31 ArcBridgeService::StopReason reason) {
35 DCHECK(delegate_); 32 DCHECK(delegate_);
36 instance_->Unbind(); 33 instance_.Unbind();
37 delegate_->OnStopped(reason); 34 delegate_->OnStopped(reason);
38 } 35 }
39 36
37 void FakeArcBridgeBootstrap::EnableBootFailureEmulation(
38 ArcBridgeService::StopReason reason) {
39 DCHECK(!boot_failure_emulation_enabled_);
40 DCHECK(!boot_suspended_);
41
42 boot_failure_emulation_enabled_ = true;
43 boot_failure_reason_ = reason;
44 }
45
46 void FakeArcBridgeBootstrap::SuspendBoot() {
47 DCHECK(!boot_failure_emulation_enabled_);
48 DCHECK(!boot_suspended_);
49
50 boot_suspended_ = true;
51 }
52
40 } // namespace arc 53 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698