Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2194153002: [test] Use all test suites with the ignition alias (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Use all test suites with the ignition alias First step of deprecating the dedicated ignition alias. Next it will be changed on the bots to use the bot_default suite. Then we'll delete it. BUG=v8:5238 Committed: https://crrev.com/1acc2f536caca0c76c919d7d5a12175ae8b84fcd Cr-Commit-Position: refs/heads/master@{#38202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M test/ignition.isolate View 1 chunk +6 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-08-01 11:13:31 UTC) #8
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-01 11:15:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194153002/1
4 years, 4 months ago (2016-08-01 11:17:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 11:19:30 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:20:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1acc2f536caca0c76c919d7d5a12175ae8b84fcd
Cr-Commit-Position: refs/heads/master@{#38202}

Powered by Google App Engine
This is Rietveld 408576698