Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2194043004: Remove the gyp_chromium hook from DEPS. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the gyp_chromium hook from DEPS. Also, add a watchlist entry for modifications to gyp files. R=brettw@chromium.org BUG=432967 Committed: https://crrev.com/cf7510864ea13c492b21928190846b658e20594d Cr-Commit-Position: refs/heads/master@{#408893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M WATCHLISTS View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-31 21:40:20 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-07-31 23:23:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194043004/1
4 years, 4 months ago (2016-07-31 23:24:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-31 23:27:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-31 23:32:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf7510864ea13c492b21928190846b658e20594d
Cr-Commit-Position: refs/heads/master@{#408893}

Powered by Google App Engine
This is Rietveld 408576698