Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index 6ccd0fc0de427713ec35a5927ff3da194ba59013..6949a4f53a73a63112ccce023706805e90c03e5c 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -27,6 +27,7 @@
#include "cc/layers/layer_collections.h"
#include "cc/layers/render_pass_sink.h"
#include "cc/output/begin_frame_args.h"
+#include "cc/output/delegating_renderer.h"
#include "cc/output/managed_memory_policy.h"
#include "cc/output/output_surface_client.h"
#include "cc/output/renderer.h"
@@ -139,7 +140,6 @@ class LayerTreeHostImplClient {
// state.
class CC_EXPORT LayerTreeHostImpl
: public InputHandler,
- public RendererClient,
public TileManagerClient,
public OutputSurfaceClient,
public TopControlsManagerClient,
@@ -247,6 +247,7 @@ class CC_EXPORT LayerTreeHostImpl
void MainThreadHasStoppedFlinging();
void DidAnimateScrollOffset();
void SetViewportDamage(const gfx::Rect& damage_rect);
+ void SetFullViewportDamage();
void SetTreeLayerFilterMutated(ElementId element_id,
LayerTreeImpl* tree,
@@ -336,9 +337,6 @@ class CC_EXPORT LayerTreeHostImpl
// Viewport rect in view space used for tiling prioritization.
const gfx::Rect ViewportRectForTilePriority() const;
- // RendererClient implementation.
- void SetFullRootLayerDamage() override;
-
// TileManagerClient implementation.
void NotifyReadyToActivate() override;
void NotifyReadyToDraw() override;
@@ -422,7 +420,7 @@ class CC_EXPORT LayerTreeHostImpl
return settings_.create_low_res_tiling && !use_gpu_rasterization_;
}
ResourcePool* resource_pool() { return resource_pool_.get(); }
- Renderer* renderer() { return renderer_.get(); }
+ DelegatingRenderer* renderer() { return renderer_.get(); }
ImageDecodeController* image_decode_controller() {
return image_decode_controller_.get();
}
@@ -566,8 +564,8 @@ class CC_EXPORT LayerTreeHostImpl
CompositorFrameMetadata MakeCompositorFrameMetadata() const;
// Viewport rectangle and clip in nonflipped window space. These rects
- // should only be used by Renderer subclasses to populate glViewport/glClip
- // and their software-mode equivalents.
+ // should only be used in the CompositorFrame to describe the physical
+ // viewport for drawing.
gfx::Rect DeviceViewport() const;
// When a SwapPromiseMonitor is created on the impl thread, it calls
@@ -742,7 +740,7 @@ class CC_EXPORT LayerTreeHostImpl
std::unique_ptr<RasterBufferProvider> raster_buffer_provider_;
std::unique_ptr<TileTaskManager> tile_task_manager_;
std::unique_ptr<ResourcePool> resource_pool_;
- std::unique_ptr<Renderer> renderer_;
+ std::unique_ptr<DelegatingRenderer> renderer_;
std::unique_ptr<ImageDecodeController> image_decode_controller_;
GlobalStateThatImpactsTilePriority global_tile_state_;

Powered by Google App Engine
This is Rietveld 408576698