Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Unified Diff: cc/output/renderer.h

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/renderer.h
diff --git a/cc/output/renderer.h b/cc/output/renderer.h
index d91e9cd71a8fdd85a0d5f4d56b91df385636ec18..2f21b377f3c928d5a2da6cea0a03af88af4c0ae7 100644
--- a/cc/output/renderer.h
+++ b/cc/output/renderer.h
@@ -23,8 +23,6 @@ class RenderPassId;
class ScopedResource;
class Task;
-typedef std::vector<std::unique_ptr<RenderPass>> RenderPassList;
-
struct RendererCapabilitiesImpl {
RendererCapabilitiesImpl();
~RendererCapabilitiesImpl();
@@ -49,56 +47,6 @@ struct RendererCapabilitiesImpl {
RendererCapabilities MainThreadCapabilities() const;
};
-class CC_EXPORT RendererClient {
- public:
- virtual void SetFullRootLayerDamage() = 0;
-};
-
-class CC_EXPORT Renderer {
- public:
- virtual ~Renderer() {}
-
- virtual const RendererCapabilitiesImpl& Capabilities() const = 0;
-
- virtual void DecideRenderPassAllocationsForFrame(
- const RenderPassList& render_passes_in_draw_order) {}
- virtual bool HasAllocatedResourcesForTesting(RenderPassId id) const;
-
- // This passes ownership of the render passes to the renderer. It should
- // consume them, and empty the list. The parameters here may change from frame
- // to frame and should not be cached.
- // The |device_viewport_rect| and |device_clip_rect| are in non-y-flipped
- // window space.
- virtual void DrawFrame(RenderPassList* render_passes_in_draw_order,
- float device_scale_factor,
- const gfx::ColorSpace& device_color_space,
- const gfx::Rect& device_viewport_rect,
- const gfx::Rect& device_clip_rect) = 0;
-
- // Waits for rendering to finish.
- virtual void Finish() = 0;
-
- // Puts backbuffer onscreen.
- virtual void SwapBuffers(CompositorFrameMetadata metadata) = 0;
- virtual void ReclaimResources(const ReturnedResourceArray& resources) {}
-
- bool visible() const { return visible_; }
- void SetVisible(bool visible);
-
- protected:
- Renderer(RendererClient* client, const RendererSettings* settings)
- : client_(client), settings_(settings), visible_(true) {}
-
- virtual void DidChangeVisibility() = 0;
-
- RendererClient* client_;
- const RendererSettings* settings_;
- bool visible_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(Renderer);
-};
-
} // namespace cc
#endif // CC_OUTPUT_RENDERER_H_

Powered by Google App Engine
This is Rietveld 408576698