Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: cc/output/gl_renderer.h

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/gl_renderer.h
diff --git a/cc/output/gl_renderer.h b/cc/output/gl_renderer.h
index 008161b952854c7bc70527bd9185b28c452b4a02..581fb875c64ef5c1e410b933e630ed452b4f0a84 100644
--- a/cc/output/gl_renderer.h
+++ b/cc/output/gl_renderer.h
@@ -50,7 +50,7 @@ class CC_EXPORT GLRenderer : public DirectRenderer {
class ScopedUseGrContext;
static std::unique_ptr<GLRenderer> Create(
- RendererClient* client,
+ DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider,
@@ -61,9 +61,6 @@ class CC_EXPORT GLRenderer : public DirectRenderer {
const RendererCapabilitiesImpl& Capabilities() const override;
- // Waits for rendering to finish.
- void Finish() override;
-
void SwapBuffers(CompositorFrameMetadata metadata) override;
void SwapBuffersComplete() override;
@@ -73,17 +70,13 @@ class CC_EXPORT GLRenderer : public DirectRenderer {
virtual bool IsContextLost();
protected:
- GLRenderer(RendererClient* client,
+ GLRenderer(DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider,
TextureMailboxDeleter* texture_mailbox_deleter,
int highp_threshold_min);
- void DidChangeVisibility() override;
-
- bool IsBackbufferDiscarded() const { return is_backbuffer_discarded_; }
-
const gfx::QuadF& SharedGeometryQuad() const { return shared_geometry_quad_; }
const StaticGeometryBinding* SharedGeometry() const {
return shared_geometry_.get();
@@ -257,10 +250,6 @@ class CC_EXPORT GLRenderer : public DirectRenderer {
void RestoreGLState();
void RestoreFramebuffer(DrawingFrame* frame);
- void DiscardBackbuffer() override;
- void EnsureBackbuffer() override;
- void EnforceMemoryPolicy();
-
void ScheduleCALayers(DrawingFrame* frame);
void ScheduleOverlays(DrawingFrame* frame);
@@ -499,7 +488,6 @@ class CC_EXPORT GLRenderer : public DirectRenderer {
gfx::Rect swap_buffer_rect_;
gfx::Rect scissor_rect_;
- bool is_backbuffer_discarded_;
bool is_using_bind_uniform_;
bool is_scissor_enabled_;
bool scissor_rect_needs_reset_;

Powered by Google App Engine
This is Rietveld 408576698