Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2193993002: [heap profiler] Use internal type links for bound this and target function. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap profiler] Use internal type links for bound this and target function. These are internal fields of the JSBoundFunction class. Committed: https://crrev.com/1fe82070719af202d21a059fa5540d3f2f4a572d Cr-Commit-Position: refs/heads/master@{#38222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/profiler/heap-snapshot-generator.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 4 months ago (2016-07-29 23:03:39 UTC) #2
ulan
lgtm
4 years, 4 months ago (2016-08-01 08:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193993002/1
4 years, 4 months ago (2016-08-01 21:19:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 22:15:27 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:16:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fe82070719af202d21a059fa5540d3f2f4a572d
Cr-Commit-Position: refs/heads/master@{#38222}

Powered by Google App Engine
This is Rietveld 408576698