Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2193983002: Generate default AP stream for highlight annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Generate default AP stream for highlight annotation. This patch generates a default AP stream for highlight annotation so that highlight annotations without AP stream can be displayed. BUG=62625 Committed: https://pdfium.googlesource.com/pdfium/+/ab47acec5252d4a09da3cbde1a118b5255fe52ae

Patch Set 1 #

Total comments: 12

Patch Set 2 : Generate default AP stream for highlight annotation. #

Total comments: 5

Patch Set 3 : Generate default AP stream for highlight annotation. #

Patch Set 4 : Generate default AP stream for highlight annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
jaepark
4 years, 4 months ago (2016-07-29 21:57:45 UTC) #2
Lei Zhang
As we discussed in person, we have failing corpus tests on the trybots. You will ...
4 years, 4 months ago (2016-07-29 22:20:50 UTC) #7
jaepark
https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp File core/fpdfdoc/cpvt_generateap.cpp (right): https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp#newcode511 core/fpdfdoc/cpvt_generateap.cpp:511: // Defaults to 0xFFFF0 color for highlight. On 2016/07/29 ...
4 years, 4 months ago (2016-07-29 23:32:26 UTC) #9
Lei Zhang
https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp File core/fpdfdoc/cpvt_generateap.cpp (right): https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp#newcode547 core/fpdfdoc/cpvt_generateap.cpp:547: pExtGStateDict->SetAt("TransGs", pTransGsDict); On 2016/07/29 23:32:26, jaepark wrote: > On ...
4 years, 4 months ago (2016-07-30 00:56:44 UTC) #10
jaepark
https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp File core/fpdfdoc/cpvt_generateap.cpp (right): https://codereview.chromium.org/2193983002/diff/1/core/fpdfdoc/cpvt_generateap.cpp#newcode547 core/fpdfdoc/cpvt_generateap.cpp:547: pExtGStateDict->SetAt("TransGs", pTransGsDict); On 2016/07/30 00:56:44, Lei Zhang wrote: > ...
4 years, 4 months ago (2016-07-30 01:28:28 UTC) #12
Lei Zhang
Looking good. We still need to update the testing repo and roll DEPS here.
4 years, 4 months ago (2016-07-30 01:32:28 UTC) #13
jaepark
Roll DEPS for testing/corpus to use updated test case for highlight annotation, which was reviewed ...
4 years, 4 months ago (2016-07-30 01:45:49 UTC) #14
Lei Zhang
lgtm
4 years, 4 months ago (2016-07-30 01:47:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193983002/100001
4 years, 4 months ago (2016-07-30 02:53:25 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 02:53:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/ab47acec5252d4a09da3cbde1a118b5255fe...

Powered by Google App Engine
This is Rietveld 408576698