src/pdf/SkPDFDevice.h - Issue 2193973002: SkPDF: PDFShader code modernized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDevice.h

Issue 2193973002: SkPDF: PDFShader code modernized. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2016-08-02 (Tuesday) 17:24:52 EDT Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDevice.h

diff --git a/src/pdf/SkPDFDevice.h b/src/pdf/SkPDFDevice.h

index d5d52f98e350a93d8f64e664f325f9aed5c917d0..5fedd0eb4ce231758af2edf8b0da4a95d3599c21 100644

--- a/src/pdf/SkPDFDevice.h

+++ b/src/pdf/SkPDFDevice.h

@@ -271,7 +271,7 @@ private:

sk_sp<SkPDFObject> makeFormXObjectFromDevice();

void drawFormXObjectWithMask(int xObjectIndex,

- SkPDFObject* mask,

+ sk_sp<SkPDFObject> mask,

const SkClipStack* clipStack,

const SkRegion& clipRegion,

SkXfermode::Mode mode,

@@ -286,9 +286,9 @@ private:

const SkMatrix& matrix,

const SkPaint& paint,

bool hasText,

- SkPDFObject** dst);

+ sk_sp<SkPDFObject>* dst);

void finishContentEntry(SkXfermode::Mode xfermode,

- SkPDFObject* dst,

+ sk_sp<SkPDFObject> dst,

SkPath* shape);

bool isContentEmpty();

« no previous file with comments | « src/pdf/SkPDFCanon.cpp ('k') | src/pdf/SkPDFDevice.cpp » ('j') | no next file with comments »