Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2193953002: MD Settings: Remove unused settings.main.rendered global variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 95ebfc6a5404287d9b6b9711d98c04c73ec9bffe..bc621f34e9f9a940584a7f59a267340c3c3c64cf 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -72,28 +72,12 @@ Polymer({
},
/** @override */
- created: function() {
- /** @private {!PromiseResolver} */
- this.resolver_ = new PromiseResolver;
- settings.main.rendered = this.resolver_.promise;
- },
-
- /** @override */
attached: function() {
document.addEventListener('toggle-advanced-page', function(e) {
this.advancedToggleExpanded_ = e.detail;
settings.navigateTo(this.advancedToggleExpanded_ ?
settings.Route.ADVANCED : settings.Route.BASIC);
}.bind(this));
-
- doWhenReady(
- function() {
- var basicPage = this.$$('settings-basic-page');
- return !!basicPage && basicPage.scrollHeight > 0;
- }.bind(this),
- function() {
- this.resolver_.resolve();
- }.bind(this));
},
/**

Powered by Google App Engine
This is Rietveld 408576698