MD Settings: Remove unused settings.main.rendered global variable.

MD Settings: Remove unused settings.main.rendered global variable.

It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9a73f324b7dce5fafea010195d4bae808225de03
Cr-Commit-Position: refs/heads/master@{#408819}

[dpapad, 2016-07-29 20:31:00]

Description was changed from

==========
MD Settings: Attempt to remove settings.main.rendered, WIP.

BUG=
==========

to

==========
MD Settings: Attempt to remove settings.main.rendered, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-29 20:44:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 20:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-29 20:44:58]

Description was changed from

==========
MD Settings: Attempt to remove settings.main.rendered, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove unused settings.main.rendered global variable.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-29 20:48:04]

Description was changed from

==========
MD Settings: Remove unused settings.main.rendered global variable.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove unused settings.main.rendered global variable.

It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-29 20:49:33]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:02:52]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2016-07-29 21:03:18]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 21:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-07-29 21:50:17]

lgtm

https://codereview.chromium.org/2193953002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):

https://codereview.chromium.org/2193953002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:64:
showManageSSLCertificates();
nit: want to further indent this while you're here doing random cleanups?

[dpapad, 2016-07-29 21:52:31]

https://codereview.chromium.org/2193953002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):

https://codereview.chromium.org/2193953002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:64:
showManageSSLCertificates();
On 2016/07/29 at 21:50:17, Dan Beam wrote:
> nit: want to further indent this while you're here doing random cleanups?

Done.

[dpapad, 2016-07-29 21:52:50]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-07-29 21:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2193953002/#ps60001
(title: "Nit.")

[commit-bot: I haz the power, 2016-07-29 21:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 23:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 23:15:30]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dpapad, 2016-07-29 23:59:34]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 00:36:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-30 00:39:22]

Description was changed from

==========
MD Settings: Remove unused settings.main.rendered global variable.

It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove unused settings.main.rendered global variable.

It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9a73f324b7dce5fafea010195d4bae808225de03
Cr-Commit-Position: refs/heads/master@{#408819}
==========

[commit-bot: I haz the power, 2016-07-30 00:39:23]

Patchset 4 (id:??) landed as
https://crrev.com/9a73f324b7dce5fafea010195d4bae808225de03
Cr-Commit-Position: refs/heads/master@{#408819}