[Android] Roll to NDK r12b.

[Android] Roll to NDK r12b.

BUG=599327
Committed: https://crrev.com/e6932bfdd0696ad971e8eb7a7ffd57755b7a4193
Cr-Commit-Position: refs/heads/master@{#416819}

[jbudorick, 2016-09-02 03:32:50]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org, stip@chromium.org

[jbudorick, 2016-09-02 03:32:51]

This also requires a DEPS roll once
https://chromium-review.googlesource.com/#/c/380499 lands.

[jbudorick, 2016-09-02 22:22:34]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-09-02 22:23:36]

This is now ready for review.

[agrieve, 2016-09-03 00:22:01]

lgtm

https://codereview.chromium.org/2193943002/diff/60001/build/config/android/BU...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/2193943002/diff/60001/build/config/android/BU...
build/config/android/BUILD.gn:117: libs = [ "c++" ]
curious why this is safe to change?

[commit-bot: I haz the power, 2016-09-03 01:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 01:16:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbudorick, 2016-09-03 18:40:00]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 18:40:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-09-03 18:41:01]

https://codereview.chromium.org/2193943002/diff/60001/build/config/android/BU...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/2193943002/diff/60001/build/config/android/BU...
build/config/android/BUILD.gn:117: libs = [ "c++" ]
On 2016/09/03 00:22:01, agrieve wrote:
> curious why this is safe to change?

Turns out it isn't :(

r12 seems to have split the contents of libc++_static.a and libc++_shared.so,
and it brought in
https://chromium.googlesource.com/android_ndk/+/master/sources/cxx-stl/llvm-l...
and
https://chromium.googlesource.com/android_ndk/+/master/sources/cxx-stl/llvm-l...
to support that. I was hoping to use those (and was able to successfully build
with them), but doing this meant that -lc++ always dynamically linked libc++.so
(even in non-component builds).

https://codereview.chromium.org/2193943002/diff/80001/build/config/android/BU...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/2193943002/diff/80001/build/config/android/BU...
build/config/android/BUILD.gn:124: libs += [
... and because -lc++ didn't work, I had to specify these explicitly.

[jbudorick, 2016-09-03 18:45:29]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 18:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 19:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 19:10:36]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[jbudorick, 2016-09-03 21:17:19]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 21:17:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 22:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 22:26:29]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-09-04 00:44:32]

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
build/config/android/BUILD.gn:125: "c++abi",
Might need to update cpplib_* with these extra libs as well:
https://cs.chromium.org/chromium/src/build/android/BUILD.gn?q=c%5C%2B%5C%2B_s...

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
build/config/android/BUILD.gn:129: if (current_cpu == "arm") {
This raises an eyebrow (needs a comment). Why only on arm? Could this be moved
to the component(s) that require it?

[jbudorick, 2016-09-05 16:32:49]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 16:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-09-05 16:33:03]

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
build/config/android/BUILD.gn:125: "c++abi",
On 2016/09/04 00:44:32, agrieve wrote:
> Might need to update cpplib_* with these extra libs as well:
>
https://cs.chromium.org/chromium/src/build/android/BUILD.gn?q=c%5C%2B%5C%2B_s...

I don't think that's necessary here; libc++_shared is the only .so. Everything
else is a static library.

https://codereview.chromium.org/2193943002/diff/120001/build/config/android/B...
build/config/android/BUILD.gn:129: if (current_cpu == "arm") {
On 2016/09/04 00:44:32, agrieve wrote:
> This raises an eyebrow (needs a comment). Why only on arm? Could this be moved
> to the component(s) that require it?

Comment added. libc++ requires it, but only on arm.
https://chromium.googlesource.com/android_ndk/+/a0190968500138134251e1c0e264d...

[commit-bot: I haz the power, 2016-09-05 17:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 17:59:01]

Dry run: This issue passed the CQ dry run.

[ghost stip (do not use), 2016-09-06 23:07:26]

rs-lgtm

[jbudorick, 2016-09-07 00:04:32]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-09-07 00:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2193943002/#ps160001
(title: "rebase: rerun all CQ bots")

[commit-bot: I haz the power, 2016-09-07 00:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 02:09:40]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-07 02:12:46]

Description was changed from

==========
[Android] Roll to NDK r12b.

BUG=599327
==========

to

==========
[Android] Roll to NDK r12b.

BUG=599327

Committed: https://crrev.com/e6932bfdd0696ad971e8eb7a7ffd57755b7a4193
Cr-Commit-Position: refs/heads/master@{#416819}
==========

[commit-bot: I haz the power, 2016-09-07 02:12:48]

Patchset 9 (id:??) landed as
https://crrev.com/e6932bfdd0696ad971e8eb7a7ffd57755b7a4193
Cr-Commit-Position: refs/heads/master@{#416819}