Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2193913002: Added Ash.SystemMenu.DefaultView.VisibleRows histogram. (Closed)

Created:
4 years, 4 months ago by bruthig
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, asvitkine+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Added Ash.SystemMenu.DefaultView.VisibleRows histogram. Added metrics to track which system menu rows are visible in order to make informed decisions about feature usage. BUG=620509 TEST=SystemTrayTest.* Review-Url: https://codereview.chromium.org/2162153002/ Cr-Commit-Position: refs/heads/master@{#407562}i (cherry picked from commit 5c85316c5787d77319c5c4fd15a1cb59dbee1fb0)

Patch Set 1 #

Patch Set 2 : Added system_tray_unittest.cc #

Patch Set 3 : Fixed up some minor differences from original patch set. #

Patch Set 4 : Merge remote-tracking branch 'refs/remotes/branch-heads/2785' into drover_2785 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -319 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/audio/tray_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/cast/tray_cast.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_network.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_sms.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_vpn.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/common/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/screen_security/screen_share_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/session/tray_session_length_limit.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/settings/tray_settings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/tray_tracing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/date/tray_date.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/system_tray_bubble.h View 3 chunks +9 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_bubble.cc View 7 chunks +55 lines, -18 lines 0 comments Download
M ash/common/system/tray/system_tray_item.h View 2 chunks +44 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_details_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/common/system/tray/tray_empty.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/common/system/tray/tray_empty.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M ash/common/system/tray/tray_image_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_image_item.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_popup_item_container.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_popup_item_container.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/common/system/update/tray_update.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/user/tray_user_separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 4 chunks +2 lines, -66 lines 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/media_security/multi_profile_media_tray_item.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 2 9 chunks +139 lines, -92 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A ash/test/test_system_tray_item.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ash/test/test_system_tray_item.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
bruthig
The CQ bit was checked by bruthig@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-29 19:08:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193913002/20001
4 years, 4 months ago (2016-07-29 19:09:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-29 19:09:01 UTC) #3
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 4 months ago (2016-07-29 19:09:03 UTC) #4
bruthig
The CQ bit was checked by bruthig@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-29 19:25:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193913002/40001
4 years, 4 months ago (2016-07-29 19:25:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-29 19:25:42 UTC) #7
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 4 months ago (2016-07-29 19:25:43 UTC) #8
bruthig
4 years, 4 months ago (2016-08-02 14:06:11 UTC) #9 
Description was changed from

==========
Added Ash.SystemMenu.DefaultView.VisibleRows histogram.

Added metrics to track which system menu rows are visible in order to
make informed decisions about feature usage.

BUG=620509
TEST=SystemTrayTest.*

Review-Url: https://codereview.chromium.org/2162153002/
Cr-Commit-Position: refs/heads/master@{#407562}i
(cherry picked from commit 5c85316c5787d77319c5c4fd15a1cb59dbee1fb0)
==========

to

==========
Added Ash.SystemMenu.DefaultView.VisibleRows histogram.

Added metrics to track which system menu rows are visible in order to
make informed decisions about feature usage.

BUG=620509
TEST=SystemTrayTest.*

Review-Url: https://codereview.chromium.org/2162153002/
Cr-Commit-Position: refs/heads/master@{#407562}i
(cherry picked from commit 5c85316c5787d77319c5c4fd15a1cb59dbee1fb0)
==========

Powered by Google App Engine
This is Rietveld 408576698