Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2193903004: Linux: Fix up sysroot_scripts. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Fix up sysroot_scripts. - Use the right repo for Ubuntu ARM(64) - Add checks for valid architectures so the "All" commands work. - Try to fix up some bashisms - And give up on the rest and just switch to bash BUG=632522 Committed: https://crrev.com/a96ed125a4d07e68c90f49f7569e11db124aef51 Cr-Commit-Position: refs/heads/master@{#408861}

Patch Set 1 #

Patch Set 2 : Check arch, fix bashishms, give up on the rest. #

Patch Set 3 : English #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M build/linux/sysroot_scripts/sysroot-creator.sh View 1 2 24 chunks +72 lines, -18 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-test.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
Lei Zhang
4 years, 4 months ago (2016-07-30 00:29:35 UTC) #2
Tom (Use chromium acct)
On 2016/07/30 00:29:35, Lei Zhang wrote: lgtm Verified that trusty script now downloads the ARM ...
4 years, 4 months ago (2016-07-30 00:43:58 UTC) #3
Lei Zhang
On 2016/07/30 00:43:58, Tom Anderson wrote: > On 2016/07/30 00:29:35, Lei Zhang wrote: > > ...
4 years, 4 months ago (2016-07-30 01:02:35 UTC) #4
Lei Zhang
PTAL
4 years, 4 months ago (2016-07-30 01:46:10 UTC) #6
Tom (Use chromium acct)
On 2016/07/30 01:46:10, Lei Zhang wrote: > PTAL lgtm
4 years, 4 months ago (2016-07-30 02:21:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193903004/60001
4 years, 4 months ago (2016-07-30 04:55:48 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-30 04:59:17 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 05:01:06 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a96ed125a4d07e68c90f49f7569e11db124aef51
Cr-Commit-Position: refs/heads/master@{#408861}

Powered by Google App Engine
This is Rietveld 408576698