Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2193873002: Roll buildtools 67bf0653b2..db9be6cbc4 (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 67bf0653b2..db9be6cbc4 In order to roll GN 15e0e74f4d..da21696cd2 (r407852:r408676) and pick up the following changes: da21696 GN: only write targets that should be generated. 1c27131 [GN] Prefer explicit pool to automatic link_pool for link targets. 8293c35 GN: don't write separate files for non-binary targets TBR=dpranke@chromium.org Committed: https://crrev.com/7619821001de878093edd06e9a73809ecae9b7f3 Cr-Commit-Position: refs/heads/master@{#408765}

Patch Set 1 #

Patch Set 2 : New one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
brettw
4 years, 4 months ago (2016-07-29 17:51:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193873002/1
4 years, 4 months ago (2016-07-29 17:51:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271494)
4 years, 4 months ago (2016-07-29 18:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193873002/1
4 years, 4 months ago (2016-07-29 19:08:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271542)
4 years, 4 months ago (2016-07-29 20:09:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193873002/20001
4 years, 4 months ago (2016-07-29 20:33:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp_rel/builds/7950)
4 years, 4 months ago (2016-07-29 20:36:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193873002/20001
4 years, 4 months ago (2016-07-29 20:52:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 21:25:22 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:26:54 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7619821001de878093edd06e9a73809ecae9b7f3
Cr-Commit-Position: refs/heads/master@{#408765}

Powered by Google App Engine
This is Rietveld 408576698