Never create an app list for an incognito profile.

chrome/browser/ui/app_list/app_list_shower.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/app_list_shower.h"
 
 AppListShower::AppListShower(scoped_ptr<AppListFactory> factory,
                              scoped_ptr<KeepAliveService> keep_alive,
                              AppListService* service)
     : factory_(factory.Pass()),
       keep_alive_service_(keep_alive.Pass()),
       service_(service),
       profile_(NULL),
       can_close_app_list_(true) {
 }
 
 AppListShower::~AppListShower() {
 }
 
 void AppListShower::ShowAndReacquireFocus(Profile* requested_profile) {
   ShowForProfile(requested_profile);
   app_list_->ReactivateOnNextFocusLoss();
 }
 
 void AppListShower::ShowForProfile(Profile* requested_profile) {
   // If the app list is already displaying |profile| just activate it (in case
   // we have lost focus).
-  if (IsAppListVisible() && (requested_profile == profile_)) {
+  if (IsAppListVisible() && (requested_profile->IsSameProfile(profile_))) {
+    DCHECK(profile_);

[benwells, 2014/10/09 05:32:33]

Are these DCHECKs related to this change or just good to adds?

[tapted, 2014/10/09 05:52:01]

semi-related. They're not being added because I tickled a bug or anything. And
It's more for the check below.

IsSameProfile(NULL) is a valid call and always returns `false`. Below that's
inverted so the `else if` there could be entered in that case, but it never will
be because `profile_ == NULL` \implies{} `app_list_ == NULL`, and the first
block will be taken.

The DCHECK is just to capture that invariant. i.e. to make it clear these blocks
are always *replacing* a profile (as opposed to the `CreateViewForProfile` path
which should always be taken if profile_ is non-NULL).

     app_list_->Show();
     return;
   }
 
   if (!app_list_) {
     CreateViewForProfile(requested_profile);
-  } else if (requested_profile != profile_) {
-    profile_ = requested_profile;
-    app_list_->SetProfile(requested_profile);
+  } else if (!requested_profile->IsSameProfile(profile_)) {
+    DCHECK(profile_);
+    profile_ = requested_profile->GetOriginalProfile();
+    app_list_->SetProfile(profile_);
   }
 
   keep_alive_service_->EnsureKeepAlive();
   if (!IsAppListVisible())
     app_list_->MoveNearCursor();
   app_list_->Show();
 }
 
 gfx::NativeWindow AppListShower::GetWindow() {
   if (!IsAppListVisible())
     return NULL;
   return app_list_->GetWindow();
 }
 
 void AppListShower::CreateViewForProfile(Profile* requested_profile) {
-  profile_ = requested_profile;
+  profile_ = requested_profile->GetOriginalProfile();
   app_list_.reset(factory_->CreateAppList(
       profile_,
       service_,
       base::Bind(&AppListShower::DismissAppList, base::Unretained(this))));
 }
 
 void AppListShower::DismissAppList() {
   if (app_list_ && can_close_app_list_) {
     app_list_->Hide();
     keep_alive_service_->FreeKeepAlive();
@@ skipping 29 matching lines @@
 
 void AppListShower::WarmupForProfile(Profile* profile) {
   DCHECK(!profile_);
   CreateViewForProfile(profile);
   app_list_->Prerender();
 }
 
 bool AppListShower::HasView() const {
   return !!app_list_;
 }