Never create an app list for an incognito profile.

chrome/browser/ui/app_list/app_list_controller_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
@@ skipping 26 matching lines @@
       browser()->profile()->GetOffTheRecordProfile(), desktop));
 
   controller->CreateNewWindow(browser()->profile(), false);
   EXPECT_EQ(2U, chrome::GetBrowserCount(browser()->profile(), desktop));
 
   controller->CreateNewWindow(browser()->profile(), true);
   EXPECT_EQ(1U, chrome::GetBrowserCount(
       browser()->profile()->GetOffTheRecordProfile(), desktop));
 }
 
+// Test creating the app list for an incognito version of the current profile.
+IN_PROC_BROWSER_TEST_F(AppListControllerBrowserTest, RegularThenIncognito) {
+  AppListService* service = test::GetAppListService();
+  // On Ash, the app list always has a profile.
+  if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH)
+    EXPECT_TRUE(service->GetCurrentAppListProfile());
+  else
+    EXPECT_FALSE(service->GetCurrentAppListProfile());
+
+  service->ShowForProfile(browser()->profile());
+  EXPECT_EQ(browser()->profile(), service->GetCurrentAppListProfile());
+
+  AppListControllerDelegate* controller = service->GetControllerDelegate();
+  service->ShowForProfile(browser()->profile()->GetOffTheRecordProfile());
+
+  // Should be showing the same profile.
+  EXPECT_EQ(browser()->profile(), service->GetCurrentAppListProfile());
+
+  // Should not have been reconstructed.
+  EXPECT_EQ(controller, service->GetControllerDelegate());
+
+  // Same set of tests using ShowForAppInstall, which the webstore uses and was
+  // traditionally where issues with incognito-mode app launchers started. Pass
+  // true for start_discovery_tracking to emulate what the webstore does on the
+  // first app install, to cover AppListServiceImpl::CreateForProfile().
+  service->ShowForAppInstall(
+      browser()->profile()->GetOffTheRecordProfile(), "", true);
+  EXPECT_EQ(browser()->profile(), service->GetCurrentAppListProfile());
+  EXPECT_EQ(controller, service->GetControllerDelegate());
+}
+
+// Test creating the initial app list for incognito profile.
+IN_PROC_BROWSER_TEST_F(AppListControllerBrowserTest, Incognito) {
+  AppListService* service = test::GetAppListService();
+  if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH)
+    EXPECT_TRUE(service->GetCurrentAppListProfile());
+  else
+    EXPECT_FALSE(service->GetCurrentAppListProfile());
+
+  service->ShowForProfile(browser()->profile()->GetOffTheRecordProfile());
+  // Initial load should have picked the non-incongito profile.
+  EXPECT_EQ(browser()->profile(), service->GetCurrentAppListProfile());
+}
+
 // Browser Test for AppListController that observes search result changes.
 class AppListControllerSearchResultsBrowserTest
     : public ExtensionBrowserTest,
       public app_list::SearchResultObserver,
       public ui::ListModelObserver {
  public:
   AppListControllerSearchResultsBrowserTest()
       : observed_result_(NULL),
         item_uninstall_count_(0),
         observed_results_list_(NULL) {}
@@ skipping 105 matching lines @@
   EXPECT_EQ(1, item_uninstall_count_);
 
   // Results should not be immediately refreshed. When they are, the item should
   // be removed from the model.
   EXPECT_TRUE(observed_result_);
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(observed_result_);
   StopWatchingResults();
   service->DismissAppList();
 }