Improve number formatting in allocation view

Source/devtools/front_end/HeapSnapshotGridNodes.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 212 matching lines @@
         return null;
     },
 
     /**
      * @param {string} columnIdentifier
      * @return {!Element}
      */
     _createValueCell: function(columnIdentifier)
     {
         var cell = document.createElement("td");
-        cell.className = columnIdentifier + "-column";
+        cell.className = "numeric-column";
         if (this.dataGrid.snapshot.totalSize !== 0) {
             var div = document.createElement("div");
             var valueSpan = document.createElement("span");
             valueSpan.textContent = this.data[columnIdentifier];
             div.appendChild(valueSpan);
             var percentColumn = columnIdentifier + "-percent";
             if (percentColumn in this.data) {
                 var percentSpan = document.createElement("span");
                 percentSpan.className = "percent-column";
                 percentSpan.textContent = this.data[percentColumn];
@@ skipping 934 matching lines @@
     createProvider: function()
     {
         var tree = this._dataGrid;
         return new WebInspector.HeapSnapshotDiffNodesProvider(
             tree.snapshot.createAddedNodesProvider(tree.baseSnapshot.uid, this._name),
             tree.baseSnapshot.createDeletedNodesProvider(this._deletedIndexes),
             this._addedCount,
             this._removedCount);
     },
 
+    /**
+     * @param {string} columnIdentifier
+     * @return {!Element}
+     */
+    createCell: function(columnIdentifier)
+    {
+        var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnIdentifier);
+        if (columnIdentifier !== "object")
+            cell.classList.add("numeric-column");
+        return cell;
+    },
+
     _createChildNode: function(item)
     {
         if (item.isAddedNotRemoved)
             return new WebInspector.HeapSnapshotInstanceNode(this._dataGrid, this._dataGrid.snapshot, item, false);
         else
             return new WebInspector.HeapSnapshotInstanceNode(this._dataGrid, this._dataGrid.baseSnapshot, item, true);
     },
 
     _childHashForEntity: function(node)
     {
@@ skipping 145 matching lines @@
 /**
  * @constructor
  * @extends {WebInspector.HeapSnapshotGridNode}
  * @param {!WebInspector.AllocationDataGrid} dataGrid
  * @param {!WebInspector.HeapSnapshotCommon.SerializedAllocationNode} data
  */
 WebInspector.AllocationGridNode = function(dataGrid, data)
 {
     WebInspector.HeapSnapshotGridNode.call(this, dataGrid, data.hasChildren);
     this._populated = false;
-    this.data = data;
+    this._allocationNode = data;
+    this.data = {
+        "liveCount": Number.withThousandsSeparator(data.liveCount),
+        "count": Number.withThousandsSeparator(data.count),
+        "liveSize": Number.withThousandsSeparator(data.liveSize),
+        "size": Number.withThousandsSeparator(data.size),
+        "name": data.name
+    };
 }
 
 WebInspector.AllocationGridNode.prototype = {
     populate: function()
     {
         if (this._populated)
             return;
         this._populated = true;
-        this._dataGrid.snapshot.allocationNodeCallers(this.data.id, didReceiveCallers.bind(this));
+        this._dataGrid.snapshot.allocationNodeCallers(this._allocationNode.id, didReceiveCallers.bind(this));
 
         /**
          * @param {!WebInspector.HeapSnapshotCommon.AllocationNodeCallers} callers
          * @this {WebInspector.AllocationGridNode}
          */
         function didReceiveCallers(callers)
         {
             var callersChain = callers.nodesWithSingleCaller;
             var parentNode = this;
             var dataGrid = /** @type {!WebInspector.AllocationDataGrid} */ (this._dataGrid);
@@ skipping 24 matching lines @@
             this.children[0].expand();
     },
 
     /**
      * @override
      * @param {string} columnIdentifier
      * @return {!Element}
      */
     createCell: function(columnIdentifier)
     {
+        if (columnIdentifier !== "name")
+            return this._createValueCell(columnIdentifier);
+
         var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnIdentifier);
-
-        if (columnIdentifier !== "name")
-            return cell;
-
-        var functionInfo = this.data;
-        if (functionInfo.scriptName) {
-            var urlElement = this._dataGrid._linkifier.linkifyLocation(functionInfo.scriptName, functionInfo.line - 1, functionInfo.column - 1, "profile-node-file");
+        var allocationNode = this._allocationNode;
+        if (allocationNode.scriptName) {
+            var urlElement = this._dataGrid._linkifier.linkifyLocation(allocationNode.scriptName, allocationNode.line - 1, allocationNode.column - 1, "profile-node-file");
             urlElement.style.maxWidth = "75%";
             cell.insertBefore(urlElement, cell.firstChild);
         }
 
         return cell;
     },
 
     /**
      * @return {number}
      */
     allocationNodeId: function()
     {
         return this.data.id;
     },
 
     __proto__: WebInspector.HeapSnapshotGridNode.prototype
 }