Improve number formatting in allocation view

Improve number formatting in allocation view

- numbers are formatted with thousands separators in the Allocation view similar to other views
- all numeric columns' text is aligned on the right hand side

BUG=277984
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170474

[alph, 2014-03-31 15:15:16]

lgtm

[yurys, 2014-03-31 15:16:13]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-03-31 15:16:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/219383003/20001

[commit-bot: I haz the power, 2014-03-31 15:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 15:16:20]

Failed to apply patch for Source/devtools/front_end/HeapSnapshotGridNodes.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/HeapSnapshotGridNodes.js
  Hunk #3 FAILED at 1362.
  Hunk #5 FAILED at 1416.
  2 out of 5 hunks FAILED -- saving rejects to file
Source/devtools/front_end/HeapSnapshotGridNodes.js.rej

Patch:       Source/devtools/front_end/HeapSnapshotGridNodes.js
Index: Source/devtools/front_end/HeapSnapshotGridNodes.js
diff --git a/Source/devtools/front_end/HeapSnapshotGridNodes.js
b/Source/devtools/front_end/HeapSnapshotGridNodes.js
index
8ecabbc8f9091aaed249fce253fcdfb6dc07befd..ddb2ebaf511dbbb06a5cd8edabaf07da904ef563
100644
--- a/Source/devtools/front_end/HeapSnapshotGridNodes.js
+++ b/Source/devtools/front_end/HeapSnapshotGridNodes.js
@@ -230,7 +230,7 @@ WebInspector.HeapSnapshotGridNode.prototype = {
     _createValueCell: function(columnIdentifier)
     {
         var cell = document.createElement("td");
-        cell.className = columnIdentifier + "-column";
+        cell.className = "numeric-column";
         if (this.dataGrid.snapshot.totalSize !== 0) {
             var div = document.createElement("div");
             var valueSpan = document.createElement("span");
@@ -1185,6 +1185,18 @@ WebInspector.HeapSnapshotDiffNode.prototype = {
             this._removedCount);
     },
 
+    /**
+     * @param {string} columnIdentifier
+     * @return {!Element}
+     */
+    createCell: function(columnIdentifier)
+    {
+        var cell =
WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this,
columnIdentifier);
+        if (columnIdentifier !== "object")
+            cell.classList.add("numeric-column");
+        return cell;
+    },
+
     _createChildNode: function(item)
     {
         if (item.isAddedNotRemoved)
@@ -1350,7 +1362,14 @@ WebInspector.AllocationGridNode = function(dataGrid,
data)
 {
     WebInspector.HeapSnapshotGridNode.call(this, dataGrid, data.hasChildren);
     this._populated = false;
-    this.data = data;
+    this._allocationNode = data;
+    this.data = {
+        "liveCount": Number.withThousandsSeparator(data.liveCount),
+        "count": Number.withThousandsSeparator(data.count),
+        "liveSize": Number.withThousandsSeparator(data.liveSize),
+        "size": Number.withThousandsSeparator(data.size),
+        "name": data.name
+    };
 }
 
 WebInspector.AllocationGridNode.prototype = {
@@ -1359,7 +1378,7 @@ WebInspector.AllocationGridNode.prototype = {
         if (this._populated)
             return;
         this._populated = true;
-        this._dataGrid.snapshot.allocationNodeCallers(this.data.id,
didReceiveCallers.bind(this));
+        this._dataGrid.snapshot.allocationNodeCallers(this._allocationNode.id,
didReceiveCallers.bind(this));
 
         /**
          * @param {!WebInspector.HeapSnapshotCommon.AllocationNodeCallers}
callers
@@ -1404,14 +1423,13 @@ WebInspector.AllocationGridNode.prototype = {
      */
     createCell: function(columnIdentifier)
     {
-        var cell =
WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this,
columnIdentifier);
-
         if (columnIdentifier !== "name")
-            return cell;
+            return this._createValueCell(columnIdentifier);
 
-        var functionInfo = this.data;
-        if (functionInfo.scriptName) {
-            var urlElement =
this._dataGrid._linkifier.linkifyLocation(functionInfo.scriptName,
functionInfo.line - 1, functionInfo.column - 1, "profile-node-file");
+        var cell =
WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this,
columnIdentifier);
+        var allocationNode = this._allocationNode;
+        if (allocationNode.scriptName) {
+            var urlElement =
this._dataGrid._linkifier.linkifyLocation(allocationNode.scriptName,
allocationNode.line - 1, allocationNode.column - 1, "profile-node-file");
             urlElement.style.maxWidth = "75%";
             cell.insertBefore(urlElement, cell.firstChild);
         }

[yurys, 2014-03-31 17:32:34]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-03-31 17:32:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/219383003/20001

[commit-bot: I haz the power, 2014-03-31 18:42:08]

Change committed as 170474