Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2193823002: A tool to disable the outdated build detector for organic installs of Chrome. (Closed)

Created:
4 years, 4 months ago by grt (UTC plus 2)
Modified:
4 years, 4 months ago
Reviewers:
S. Ganesh, Nico, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A tool to disable the outdated build detector for organic installs of Chrome. BUG=623986 Committed: https://crrev.com/5d9106b31729e6ca2f8d995ccd7aa21484fd6da9 Cr-Commit-Position: refs/heads/master@{#410031}

Patch Set 1 #

Patch Set 2 : Chromium support for the sake of testing #

Patch Set 3 : format tweak #

Total comments: 10

Patch Set 4 : sync to position 409167 #

Patch Set 5 : review comments #

Patch Set 6 : add support for GoogleUpdateIsMachine env var #

Total comments: 2

Patch Set 7 : all paths are reported as custom error failures #

Patch Set 8 : sync to position 410015 #

Patch Set 9 : fix chromium.fyi.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1042 lines, -0 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google/google_brand.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/BUILD.gn View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/constants.h View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/constants.cc View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.h View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc View 1 2 3 4 5 6 1 chunk +110 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.gyp View 1 1 chunk +123 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_exe_version.rc.version View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_main.cc View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_unittest.cc View 1 2 3 4 5 6 1 chunk +185 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_unittests.isolate View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/google_update_integration.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/google_update_integration.cc View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/google_update_integration_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/tools/disable_outdated_build_detector/run_all_unittests.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 5 6 7 8 19 chunks +114 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 7 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 59 (40 generated)
grt (UTC plus 2)
Hi Ganesh. This is ready for review. Thanks.
4 years, 4 months ago (2016-08-01 09:52:43 UTC) #12
S. Ganesh
lgtm https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest File chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest (right): https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest#newcode1 chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest:1: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> Maybe add in the ...
4 years, 4 months ago (2016-08-01 22:27:25 UTC) #13
grt (UTC plus 2)
Thanks https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest File chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest (right): https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest#newcode1 chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.exe.manifest:1: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> On 2016/08/01 22:27:25, S. ...
4 years, 4 months ago (2016-08-02 06:36:20 UTC) #14
grt (UTC plus 2)
+dpranke for build/, testing/, and general GN review +thakis for chrome/ OWNERS review Thanks.
4 years, 4 months ago (2016-08-02 07:04:39 UTC) #20
Dirk Pranke
lgtm. Arguably you don't need the .gyp and .isolate file changes, but it's up to ...
4 years, 4 months ago (2016-08-02 17:27:41 UTC) #23
Nico
lgtm https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/OWNERS File chrome/tools/disable_outdated_build_detector/OWNERS (right): https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/OWNERS#newcode1 chrome/tools/disable_outdated_build_detector/OWNERS:1: grt@chromium.org nit: owners files should contain at least ...
4 years, 4 months ago (2016-08-02 17:44:00 UTC) #24
grt (UTC plus 2)
Ganesh: I've added support for the GoogleUpdateIsMachine env var. Please take another look. Thanks. https://codereview.chromium.org/2193823002/diff/120001/chrome/tools/disable_outdated_build_detector/BUILD.gn ...
4 years, 4 months ago (2016-08-03 14:14:25 UTC) #30
S. Ganesh
https://codereview.chromium.org/2193823002/diff/200001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc File chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc (right): https://codereview.chromium.org/2193823002/diff/200001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc#newcode110 chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc:110: result_info.installer_result = InstallerResult::SUCCESS; Perhaps it is best to always ...
4 years, 4 months ago (2016-08-04 00:29:22 UTC) #33
grt (UTC plus 2)
https://codereview.chromium.org/2193823002/diff/200001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc File chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc (right): https://codereview.chromium.org/2193823002/diff/200001/chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc#newcode110 chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc:110: result_info.installer_result = InstallerResult::SUCCESS; On 2016/08/04 00:29:22, S. Ganesh wrote: ...
4 years, 4 months ago (2016-08-04 12:38:01 UTC) #35
S. Ganesh
lgtm
4 years, 4 months ago (2016-08-04 21:24:00 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193823002/220001
4 years, 4 months ago (2016-08-05 08:07:03 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231792)
4 years, 4 months ago (2016-08-05 08:12:42 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193823002/260001
4 years, 4 months ago (2016-08-05 08:38:16 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/255947)
4 years, 4 months ago (2016-08-05 09:31:32 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193823002/260001
4 years, 4 months ago (2016-08-05 09:36:34 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/116859)
4 years, 4 months ago (2016-08-05 10:17:45 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193823002/260001
4 years, 4 months ago (2016-08-05 11:00:16 UTC) #55
commit-bot: I haz the power
Committed patchset #9 (id:260001)
4 years, 4 months ago (2016-08-05 11:31:18 UTC) #57
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 11:33:02 UTC) #59
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/5d9106b31729e6ca2f8d995ccd7aa21484fd6da9
Cr-Commit-Position: refs/heads/master@{#410031}

Powered by Google App Engine
This is Rietveld 408576698