Add parser finalization step

test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "src/compiler-dispatcher/compiler-dispatcher-job.h"
 #include "src/flags.h"
 #include "src/isolate-inl.h"
 #include "test/unittests/test-utils.h"
@@ skipping 31 matching lines @@
                  ->NewExternalStringFromOneByte(maybe_resource)
                  .ToHandleChecked();
   } else {
     source = isolate->factory()->NewStringFromStaticChars("source");
   }
   Handle<Script> script = isolate->factory()->NewScript(source);
   Handle<SharedFunctionInfo> shared = isolate->factory()->NewSharedFunctionInfo(
       isolate->factory()->NewStringFromStaticChars("f"), MaybeHandle<Code>(),
       false);
   SharedFunctionInfo::SetScript(shared, script);
+  shared->set_end_position(source->length() - 1);

[jochen (gone - plz use gerrit), 2016/07/29 12:23:31]

is that correct? or should it be just source->length()

   Handle<JSFunction> function =
       isolate->factory()->NewFunctionFromSharedFunctionInfo(
           shared, handle(isolate->context(), isolate));
   return scope.CloseAndEscape(function);
 }
 
 }  // namespace
 
 TEST_F(CompilerDispatcherJobTest, Construct) {
-  Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate());
   std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
-      i_isolate, CreateFunction(i_isolate, nullptr), FLAG_stack_size));
+      i_isolate(), CreateFunction(i_isolate(), nullptr), FLAG_stack_size));
 }
 
 TEST_F(CompilerDispatcherJobTest, CanParseOnBackgroundThread) {
-  Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate());
   {
     std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
-        i_isolate, CreateFunction(i_isolate, nullptr), FLAG_stack_size));
+        i_isolate(), CreateFunction(i_isolate(), nullptr), FLAG_stack_size));
     ASSERT_FALSE(job->can_parse_on_background_thread());
   }
   {
     ScriptResource script("script", strlen("script"));
     std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
-        i_isolate, CreateFunction(i_isolate, &script), FLAG_stack_size));
+        i_isolate(), CreateFunction(i_isolate(), &script), FLAG_stack_size));
     ASSERT_TRUE(job->can_parse_on_background_thread());

[vogelheim, 2016/07/29 12:46:18]

How can this still work? I don't think this var is being set?

[jochen (gone - plz use gerrit), 2016/07/29 12:49:42]

it's set in the ctor of the job

   }
 }
 
 TEST_F(CompilerDispatcherJobTest, StateTransitions) {
-  Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate());
   std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
-      i_isolate, CreateFunction(i_isolate, nullptr), FLAG_stack_size));
+      i_isolate(), CreateFunction(i_isolate(), nullptr), FLAG_stack_size));
 
   ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
   job->PrepareToParseOnMainThread();
   ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToParse);
   job->Parse();
   ASSERT_TRUE(job->status() == CompileJobStatus::kParsed);
+  job->FinalizeParsingOnMainThread();
+  ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToCompile);
+}
+
+TEST_F(CompilerDispatcherJobTest, SyntaxError) {
+  ScriptResource script("^^^", strlen("^^^"));
+  std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
+      i_isolate(), CreateFunction(i_isolate(), &script), FLAG_stack_size));
+
+  job->PrepareToParseOnMainThread();
+  job->Parse();
+  job->FinalizeParsingOnMainThread();
+
+  ASSERT_TRUE(job->status() == CompileJobStatus::kFailed);
+  ASSERT_FALSE(i_isolate()->has_pending_exception());
+  job->ReportErrorsOnMainThread();
+  ASSERT_TRUE(job->status() == CompileJobStatus::kDone);
+  ASSERT_TRUE(i_isolate()->has_pending_exception());
 }
 
 }  // namespace internal
 }  // namespace v8