Add parser finalization step

src/compiler-dispatcher/compiler-dispatcher-job.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler-dispatcher/compiler-dispatcher-job.h"
 
 #include "src/assert-scope.h"
 #include "src/global-handles.h"
 #include "src/isolate.h"
 #include "src/objects-inl.h"
@@ skipping 28 matching lines @@
 void CompilerDispatcherJob::PrepareToParseOnMainThread() {
   DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
   DCHECK(status() == CompileJobStatus::kInitial);
   HandleScope scope(isolate_);
   unicode_cache_.reset(new UnicodeCache());
   zone_.reset(new Zone(isolate_->allocator()));
   Handle<SharedFunctionInfo> shared(function_->shared(), isolate_);
   Handle<Script> script(Script::cast(shared->script()), isolate_);
   Handle<String> source(String::cast(script->source()), isolate_);
   if (source->IsExternalTwoByteString()) {
-    can_parse_on_background_thread_ = true;
     character_stream_.reset(new ExternalTwoByteStringUtf16CharacterStream(
         Handle<ExternalTwoByteString>::cast(source), shared->start_position(),
         shared->end_position()));
   } else if (source->IsExternalOneByteString()) {
-    can_parse_on_background_thread_ = true;
     character_stream_.reset(new ExternalOneByteStringUtf16CharacterStream(
         Handle<ExternalOneByteString>::cast(source), shared->start_position(),
         shared->end_position()));
   } else {
-    can_parse_on_background_thread_ = false;

[vogelheim, 2016/07/29 12:46:18]

If the variable is no longer used, pls remove from class declaration.

+    source = String::Flatten(source);
+    source_ = Handle<String>::cast(isolate_->global_handles()->Create(*source));

[jochen (gone - plz use gerrit), 2016/07/29 12:23:31]

have to globalize the reference here, so it survives between function calls

[marja, 2016/08/01 07:50:24]

How about putting this comment into the source code :)

     character_stream_.reset(new GenericStringUtf16CharacterStream(
-        source, shared->start_position(), shared->end_position()));
+        source_, shared->start_position(), shared->end_position()));
   }
   parse_info_.reset(new ParseInfo(zone_.get()));
   parse_info_->set_isolate(isolate_);
   parse_info_->set_character_stream(character_stream_.get());
   parse_info_->set_hash_seed(isolate_->heap()->HashSeed());
   parse_info_->set_unicode_cache(unicode_cache_.get());
   parser_.reset(new Parser(parse_info_.get()));
   status_ = CompileJobStatus::kReadyToParse;
 }
 
@@ skipping 14 matching lines @@
       reinterpret_cast<uintptr_t>(&stack_limit) - max_stack_size_ * KB;
 
   parser_->set_stack_limit(stack_limit);
   parser_->ParseOnBackground(parse_info_.get());
 
   parse_info_->set_isolate(isolate_);
 
   status_ = CompileJobStatus::kParsed;
 }
 
+void CompilerDispatcherJob::FinalizeParsingOnMainThread() {
+  DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
+  DCHECK(status() == CompileJobStatus::kParsed);
+
+  if (!source_.is_null()) {
+    i::GlobalHandles::Destroy(Handle<Object>::cast(source_).location());
+  }
+
+  if (parse_info_->literal() == nullptr) {
+    status_ = CompileJobStatus::kFailed;
+    return;
+  }
+
+  InternalizeParsingResult();
+
+  status_ = CompileJobStatus::kReadyToCompile;
+}
+
+void CompilerDispatcherJob::ReportErrorsOnMainThread() {
+  DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
+  DCHECK(status() == CompileJobStatus::kFailed);
+
+  // Internalizing the parsing result will throw the error.
+  InternalizeParsingResult();
+
+  status_ = CompileJobStatus::kDone;
+}
+
+void CompilerDispatcherJob::InternalizeParsingResult() {
+  DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
+  DCHECK(status() == CompileJobStatus::kParsed ||
+         status() == CompileJobStatus::kFailed);
+
+  HandleScope scope(isolate_);
+  Handle<SharedFunctionInfo> shared(function_->shared(), isolate_);
+  Handle<Script> script(Script::cast(shared->script()), isolate_);
+
+  parse_info_->set_script(script);
+  parse_info_->set_context(handle(function_->context(), isolate_));
+
+  // Do the parsing tasks which need to be done on the main thread. This will
+  // also handle parse errors.
+  parser_->Internalize(isolate_, script, parse_info_->literal() == nullptr);
+  parser_->HandleSourceURLComments(isolate_, script);
+
+  parse_info_->set_character_stream(nullptr);
+  parse_info_->set_unicode_cache(nullptr);
+  parser_.reset();
+  unicode_cache_.reset();
+  character_stream_.reset();

[vogelheim, 2016/07/29 12:46:18]

[general comment:]

Since this class handles more & more resources, IMHO you should in the
destructor either:
- assert a proper terminal state (kFailed or kCompiled)
- or enforce cleanup in the destructor.

I prefer the former, since I guess the intention is that the dispatcher should
run the state machine to its proper end (& hence the job-class can assume it
will go through the proper life cycle).

Loosely related: If the intention is that the dispatcher controls the lifecycle,
I guess the job (eventually...) needs some sort of 'discard' edges in the state
machine, so that the dispatcher can cleanly abandon jobs.

[jochen (gone - plz use gerrit), 2016/07/29 12:49:42]

yeah, that makes sense

+}
+
 }  // namespace internal
 }  // namespace v8