Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2193803002: Enable IO in WebRtcAudioDebugRecordingsBrowserTest (Closed)

Created:
4 years, 4 months ago by ehmaldonado_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, tnakamura+watch_chromium.org, jam, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IO in WebRtcAudioDebugRecordingsBrowserTest Set base::ThreadRestrictions::SetIOAllowed(), since the tests need to create a temporary file. BUG=632685 Committed: https://crrev.com/609d45d312e6ba0c642cdbad369facbb91529735 Cr-Commit-Position: refs/heads/master@{#408619}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 7 chunks +12 lines, -16 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_chromium
4 years, 4 months ago (2016-07-29 11:21:45 UTC) #3
phoglund_chromium
lgtm
4 years, 4 months ago (2016-07-29 11:31:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193803002/1
4 years, 4 months ago (2016-07-29 11:32:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 12:19:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/609d45d312e6ba0c642cdbad369facbb91529735 Cr-Commit-Position: refs/heads/master@{#408619}
4 years, 4 months ago (2016-07-29 12:22:29 UTC) #11
tommi (sloooow) - chröme
4 years, 4 months ago (2016-07-29 17:17:34 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2193803002/diff/1/content/browser/media/webrt...
File content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc
(right):

https://codereview.chromium.org/2193803002/diff/1/content/browser/media/webrt...
content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc:99:
bool prev = base::ThreadRestrictions::SetIOAllowed(true);
Use ScopedAllowIO?

Powered by Google App Engine
This is Rietveld 408576698