Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2193783002: Add build configuration for experimental Windows GDI code. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add build configuration for experimental Windows GDI code. BUG=409472 Committed: https://pdfium.googlesource.com/pdfium/+/3e454bfb00089eb022ee0b09e1631dbd61e324c4

Patch Set 1 #

Total comments: 1

Patch Set 2 : wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build_overrides/pdfium.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M pdfium.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Lei Zhang
https://codereview.chromium.org/2193783002/diff/1/pdfium.gni File pdfium.gni (right): https://codereview.chromium.org/2193783002/diff/1/pdfium.gni#newcode23 pdfium.gni:23: # Build PDFium with experimental win32 GDI APIs. Will ...
4 years, 4 months ago (2016-07-29 15:57:25 UTC) #6
Lei Zhang
+tsepez if you want to stamp this. It's a follow up to https://codereview.chromium.org/2113563003 so we ...
4 years, 4 months ago (2016-07-29 21:19:05 UTC) #8
Tom Sepez
Stampy Stamp LGTM
4 years, 4 months ago (2016-07-29 22:13:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193783002/20001
4 years, 4 months ago (2016-07-29 23:15:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/3e454bfb00089eb022ee0b09e1631dbd61e324c4
4 years, 4 months ago (2016-07-29 23:29:07 UTC) #13
dsinclair
4 years, 4 months ago (2016-07-30 02:37:14 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698