Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2193773002: Revert of Comment out some infobar identifiers for obsolete infobars. (Closed)

Created:
4 years, 4 months ago by jif
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Comment out some infobar identifiers for obsolete infobars. (patchset #1 id:1 of https://codereview.chromium.org/2189963002/ ) Reason for revert: Very sorry to revert this, but both READER_MODE_INFOBAR_DELEGATE and UPGRADE_INFOBAR_DELEGATE are still used by Chrome iOS. Original issue's description: > Comment out some infobar identifiers for obsolete infobars. > > BUG=none > > Committed: https://crrev.com/c283644ddac0839170780ef5e3c78798db5b293b > Cr-Commit-Position: refs/heads/master@{#408454} TBR=pkasting@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/a42e8b81874bea9d61f5b8c99574f058263652a9 Cr-Commit-Position: refs/heads/master@{#408606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/infobars/core/infobar_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jif
Created Revert of Comment out some infobar identifiers for obsolete infobars.
4 years, 4 months ago (2016-07-29 09:04:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193773002/1
4 years, 4 months ago (2016-07-29 09:04:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 09:05:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a42e8b81874bea9d61f5b8c99574f058263652a9 Cr-Commit-Position: refs/heads/master@{#408606}
4 years, 4 months ago (2016-07-29 09:07:06 UTC) #6
Evan Stade
4 years, 4 months ago (2016-07-29 17:06:06 UTC) #7
Message was sent while issue was closed.
if this kind of thing is not checked by the CQ it's going to keep breaking. Also
you don't need to revert the entire patch.

Powered by Google App Engine
This is Rietveld 408576698