Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: extensions/common/features/simple_feature_unittest.cc

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/simple_feature_unittest.cc
diff --git a/extensions/common/features/simple_feature_unittest.cc b/extensions/common/features/simple_feature_unittest.cc
index 2f40b81083befc0f0c6353259130194f1fa5b1da..8ca6aecbe94cf1e6f6f2d3d866522b33fc9a69ec 100644
--- a/extensions/common/features/simple_feature_unittest.cc
+++ b/extensions/common/features/simple_feature_unittest.cc
@@ -881,11 +881,10 @@ TEST_F(SimpleFeatureTest, SimpleFeatureAvailability) {
feature2->channel_.reset(
new version_info::Channel(version_info::Channel::BETA));
feature2->extension_types_.push_back(Manifest::TYPE_LEGACY_PACKAGED_APP);
- std::unique_ptr<ComplexFeature::FeatureList> list(
- new ComplexFeature::FeatureList());
- list->push_back(std::move(feature1));
- list->push_back(std::move(feature2));
- complex_feature.reset(new ComplexFeature(std::move(list)));
+ std::vector<Feature*> list;
+ list.push_back(feature1.release());
+ list.push_back(feature2.release());
+ complex_feature.reset(new ComplexFeature(list));
}
Feature* feature = static_cast<Feature*>(complex_feature.get());
@@ -936,11 +935,10 @@ TEST_F(SimpleFeatureTest, ComplexFeatureAvailability) {
feature2->channel_.reset(
new version_info::Channel(version_info::Channel::STABLE));
feature2->extension_types_.push_back(Manifest::TYPE_LEGACY_PACKAGED_APP);
- std::unique_ptr<ComplexFeature::FeatureList> list(
- new ComplexFeature::FeatureList());
- list->push_back(std::move(feature1));
- list->push_back(std::move(feature2));
- complex_feature.reset(new ComplexFeature(std::move(list)));
+ std::vector<Feature*> list;
+ list.push_back(feature1.release());
+ list.push_back(feature2.release());
+ complex_feature.reset(new ComplexFeature(list));
}
Feature* feature = static_cast<Feature*>(complex_feature.get());

Powered by Google App Engine
This is Rietveld 408576698