extensions/common/features/json_feature_provider.cc - Issue 2193693003: Further reduction of feature_compiler.py generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/json_feature_provider.cc

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/features/complex_feature.cc ('K') | « extensions/common/features/complex_feature.cc ('k') | tools/json_schema_compiler/feature_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/json_feature_provider.cc

diff --git a/extensions/common/features/json_feature_provider.cc b/extensions/common/features/json_feature_provider.cc

index ab5e026efde740b3a430804519dfde84d9bf6ea3..53003a98065f9452111b7485a32ba7660e271a59 100644

--- a/extensions/common/features/json_feature_provider.cc

+++ b/extensions/common/features/json_feature_provider.cc

@@ -131,14 +131,14 @@ JSONFeatureProvider::JSONFeatureProvider(const base::DictionaryValue& root,

if (!ParseFeature(dict, iter.key(), feature.get()))

continue;

- features->push_back(std::move(feature));

+ features->push_back(feature.release());

}

std::unique_ptr<ComplexFeature> feature(

- new ComplexFeature(std::move(features)));

+ new ComplexFeature(features.release()));

feature->set_name(iter.key());

- AddFeature(iter.key(), std::move(feature));

+ AddFeature(iter.key(), feature.release());

} else {

LOG(ERROR) << iter.key() << ": Feature description must be dictionary or"

<< " list of dictionaries.";