Further reduction of feature_compiler.py generated code

extensions/common/features/complex_feature.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/complex_feature.h"
 
+#include "base/stl_util.h"
+
 namespace extensions {
 
-ComplexFeature::ComplexFeature(std::unique_ptr<FeatureList> features) {
+ComplexFeature::ComplexFeature(FeatureList* features) {
   DCHECK_GT(features->size(), 0UL);
   features_.swap(*features);
   no_parent_ = features_[0]->no_parent();
 
 #if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
   // Verify IsInternal and no_parent is consistent across all features.
   bool first_is_internal = features_[0]->IsInternal();
   for (FeatureList::const_iterator it = features_.begin() + 1;
        it != features_.end();
        ++it) {
     DCHECK(first_is_internal == (*it)->IsInternal())
         << "Complex feature must have consistent values of "
            "internal across all sub features.";
     DCHECK(no_parent_ == (*it)->no_parent())
         << "Complex feature must have consistent values of "
            "no_parent across all sub features.";
   }
 #endif
 }
 
 ComplexFeature::~ComplexFeature() {
+  STLDeleteElements(&features_);

[Devlin, 2016/07/29 18:50:14]

This makes me a bit sad.

Since we control the construction of the FeatureList and can avoid the
wrapping/unwrapping of all the unique_ptrs a bit more, is using raw ptrs still a
huge win over unique_ptrs here?

(I also notice that FeatureProvider's map still uses unique_ptrs - I'd think the
two containers would be similar.  So, conversely, if this *is* a big win, should
we do the same to the map?)

[scottmg, 2016/07/29 20:05:04]

Is something like this what you had in mind?

I'm not sure what you mean with FeatureProvider. The reason FeatureList was
changed was to avoid all the unique_ptr wrap/unwrap in the generated code. In
the actual implementation of ComplexFeature it's irrelevant.

 }
 
 Feature::Availability ComplexFeature::IsAvailableToManifest(
     const std::string& extension_id,
     Manifest::Type type,
     Manifest::Location location,
     int manifest_version,
     Platform platform) const {
   Feature::Availability first_availability =
       features_[0]->IsAvailableToManifest(
@@ skipping 55 matching lines @@
   return false;
 }
 
 bool ComplexFeature::IsInternal() const {
   // Constructor verifies that composed features are consistent, thus we can
   // return just the first feature's value.
   return features_[0]->IsInternal();
 }
 
 }  // namespace extensions