third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp - Issue 2193683004: Move ThreadableLoader to Oilpan heap (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 2193683004: Move ThreadableLoader to Oilpan heap (3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h ('K') | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h ('k') | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

index 828ef917704804ab6a8229e1196b0b6d1507b648..c5f24d2c278f9820bc991da4bda2dfd0dbbbd7ea 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

@@ -341,7 +341,7 @@ void DocumentThreadableLoader::makeCrossOriginAccessRequest(const ResourceReques

DocumentThreadableLoader::~DocumentThreadableLoader()

{

CHECK(!m_client);

- DCHECK(!m_resource);

+ DCHECK(!resource());

}

void DocumentThreadableLoader::overrideTimeout(unsigned long timeoutMilliseconds)

@@ -968,9 +968,9 @@ Document& DocumentThreadableLoader::document() const

DEFINE_TRACE(DocumentThreadableLoader)

{

- visitor->trace(m_resource);

visitor->trace(m_document);

ThreadableLoader::trace(visitor);

+ ResourceOwner<RawResource>::trace(visitor);

}

} // namespace blink