Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2193683003: Move WebAPK <meta-data> to org.chromium.webapk.shell_apk namespace (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebAPK <meta-data> to org.chromium.webapk.shell_apk namespace BUG=631063 Committed: https://crrev.com/fa286b9db313e3ab6ca76ae6585068267e43962a Cr-Commit-Position: refs/heads/master@{#408637}

Patch Set 1 : Merge branch 'master' into meta_namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java View 1 chunk +14 lines, -10 lines 0 comments Download
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
Xi can you please take a look?
4 years, 4 months ago (2016-07-29 00:18:08 UTC) #3
Xi Han
lgtm
4 years, 4 months ago (2016-07-29 13:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193683003/20001
4 years, 4 months ago (2016-07-29 14:39:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-07-29 15:20:46 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:22:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa286b9db313e3ab6ca76ae6585068267e43962a
Cr-Commit-Position: refs/heads/master@{#408637}

Powered by Google App Engine
This is Rietveld 408576698