[SVGDom] Parse style attributes

[SVGDom] Parse style attributes

Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.

R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193663002

Committed: https://skia.googlesource.com/skia/+/58649ccc75c033ea4e0c9a664b4ed178816a50c6

[f(malita), 2016-07-28 23:18:40]

Description was changed from

==========
[SVGDom] Parse style attributes

Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.

R=reed@google.com,robertphillips@google.com
==========

to

==========
[SVGDom] Parse style attributes

Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.

R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193663002
==========

[f(malita), 2016-07-28 23:30:55]

As Mike pointed out, lots of existing SVG content (e.g.
https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/) bundle attributes as
style.

[f(malita), 2016-07-28 23:31:05]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 23:31:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 00:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 00:17:22]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-29 11:37:28]

lgtm

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:14: enum class SkSVGAttribute {
Shouldn't these still be prefaced with a 'k' ?

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
File experimental/svg/model/SkSVGDOM.cpp (right):

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
experimental/svg/model/SkSVGDOM.cpp:190: { "stroke",    {
SkSVGAttribute::stroke,    SetPaintAttribute     }},
Where in the spec is the 'style' attribute discussed?

[f(malita), 2016-07-29 13:04:05]

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:14: enum class SkSVGAttribute {
On 2016/07/29 11:37:28, robertphillips wrote:
> Shouldn't these still be prefaced with a 'k' ?

I wasn't sure how we handle new-style enums classes in Skia:

SkSVGAttribute::kFill_Attribute (old style now seems repetitive)
SkSVGAttribute::kFill           (seems OK)
SkSVGAttribute::fill            (seems cute to call attributes by their actual
name)

But I see in other places we use option #2 - so then it's settled :)

Done (also for SkSVGTag).

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
File experimental/svg/model/SkSVGDOM.cpp (right):

https://codereview.chromium.org/2193663002/diff/20001/experimental/svg/model/...
experimental/svg/model/SkSVGDOM.cpp:190: { "stroke",    {
SkSVGAttribute::stroke,    SetPaintAttribute     }},
On 2016/07/29 11:37:28, robertphillips wrote:
> Where in the spec is the 'style' attribute discussed?

https://www.w3.org/TR/SVG/styling.html#StyleAttribute

Most of the style props get mapped to the awful presentation attributes.

[f(malita), 2016-07-29 13:06:13]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 13:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 13:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 13:50:29]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-07-29 15:51:02]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-07-29 15:51:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2193663002/#ps40001
(title: "rename enums")

[commit-bot: I haz the power, 2016-07-29 15:51:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:52:05]

Description was changed from

==========
[SVGDom] Parse style attributes

Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.

R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193663002
==========

to

==========
[SVGDom] Parse style attributes

Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.

R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193663002

Committed:
https://skia.googlesource.com/skia/+/58649ccc75c033ea4e0c9a664b4ed178816a50c6
==========

[commit-bot: I haz the power, 2016-07-29 15:52:07]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/58649ccc75c033ea4e0c9a664b4ed178816a50c6