Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2193653002: chrome/browser/notifications: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/notifications: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=dewittj@chromium.org BUG=554600 Committed: https://crrev.com/d11ed91e72f49c6ec0d9cd2a3d5ae7bfe451b618 Cr-Commit-Position: refs/heads/master@{#408713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-28 23:43:12 UTC) #1
dewittj
lgtm, thanks!
4 years, 4 months ago (2016-07-29 18:10:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193653002/1
4 years, 4 months ago (2016-07-29 18:36:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:18:50 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:20:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d11ed91e72f49c6ec0d9cd2a3d5ae7bfe451b618
Cr-Commit-Position: refs/heads/master@{#408713}

Powered by Google App Engine
This is Rietveld 408576698