Make GetFilesChanged work with copied files.

Make GetFilesChanged work with copied files.

BUG=358028
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261466

[jbudorick, 2014-03-31 22:49:45]

Includes test cases for GetFilesChanged. At the moment, I just want them around
for manual testing. I should be able to convert them in the android_commands
refactor. The included testGetFilesChangedCopy fails without the changes to
android_commands.py and passes with them. (All of the other tests pass both with
and without the changes.)

[craigdh, 2014-04-01 15:24:32]

lgtm. kudos for adding some test cases.

https://codereview.chromium.org/219363006/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/219363006/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:983: def RelToRealPaths(rel_path):
putting a blank line on either side of inline functions aids readability

[jbudorick, 2014-04-01 15:29:00]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-04-01 15:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/219363006/20001

[commit-bot: I haz the power, 2014-04-01 20:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 20:51:11]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[craigdh, 2014-04-01 20:58:13]

On 2014/04/01 20:51:11, I haz the power (commit-bot) wrote:
> The commit queue went berserk retrying too often for a
> seemingly flaky test on builder android_dbg:
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

you sure you didn't break anything here? :)

[jbudorick, 2014-04-01 23:02:16]

On 2014/04/01 20:58:13, craigdh wrote:
> On 2014/04/01 20:51:11, I haz the power (commit-bot) wrote:
> > The commit queue went berserk retrying too often for a
> > seemingly flaky test on builder android_dbg:
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> 
> you sure you didn't break anything here? :)

Ha, no, I'm not. There might be another test case in the next patch...

[jbudorick, 2014-04-03 15:06:12]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/219363006/40001

[craigdh, 2014-04-03 15:11:30]

On 2014/04/03 15:07:46, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/jbudorick@chromium.org/219363006/40001

lgtm.

[commit-bot: I haz the power, 2014-04-03 17:39:03]

Change committed as 261466