Issue 219363004: Send Finch experiment selection data to ad-service at Google so QUIC performance can be evaluated

Issue 219363004: Send Finch experiment selection data to ad-service at Google so QUIC performance can be evaluated (Closed)

Created:
6 years, 8 months ago by jar (doing other things)

Modified:
6 years, 8 months ago

Reviewers:
aseemk, Alexei Svitkine (slow)

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, aseemk, kleber_google.com, Ryan Hamilton, alyssar

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Send Finch experiment selection data to ad-services @ google so QUIC performance can be evaluated r=asvitkine BUG=358241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260929

Patch Set 2 : rebase and move comment #

Patch Set 3 : Augment comment to mention additional domains. #

Total comments: 2

Patch Set 4 : Extend unit tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -4 lines)			Patch
	M	chrome/browser/metrics/variations/variations_http_header_provider.cc	View	1 2 3	2 chunks	+14 lines, -2 lines	0 comments	Download
	M	chrome/browser/metrics/variations/variations_http_header_provider_unittest.cc	View	1 2 3	1 chunk	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

Can you expand variations_http_header_provider_unittest.cc with cases for the new domains? https://codereview.chromium.org/219363004/diff/30001/chrome/browser/metrics/variations/variations_http_header_provider.cc File chrome/browser/metrics/variations/variations_http_header_provider.cc (right): https://codereview.chromium.org/219363004/diff/30001/chrome/browser/metrics/variations/variations_http_header_provider.cc#newcode193 ...

6 years, 8 months ago (2014-04-01 15:16:48 UTC) #3

jar (doing other things)

Alexei: I extended the unit test to include the new domains. PTAL. https://codereview.chromium.org/219363004/diff/30001/chrome/browser/metrics/variations/variations_http_header_provider.cc File chrome/browser/metrics/variations/variations_http_header_provider.cc ...

6 years, 8 months ago (2014-04-01 16:55:41 UTC) #4

jar (doing other things)

The CQ bit was checked by jar@chromium.org

6 years, 8 months ago (2014-04-01 18:03:17 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/219363004/50001

6 years, 8 months ago (2014-04-01 18:04:00 UTC) #7

Message was sent while issue was closed.

Change committed as 260929

Expand Messages | Collapse Messages