Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/devtools/front_end/TimelinePanel.js

Issue 219363002: Timeline: replace showAggregatedStatsInDetails with a more generic showInDetails (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/TimelineView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 890 matching lines...) Expand 10 before | Expand all | Expand 10 after
901 * @this {WebInspector.TimelinePanel} 901 * @this {WebInspector.TimelinePanel}
902 */ 902 */
903 function showCallback(element) 903 function showCallback(element)
904 { 904 {
905 this._detailsView.setContent(record.title(), element); 905 this._detailsView.setContent(record.title(), element);
906 } 906 }
907 }, 907 },
908 908
909 /** 909 /**
910 * @param {string} title 910 * @param {string} title
911 * @param {!Object} aggregatedStats 911 * @param {!Node} node
912 */ 912 */
913 showAggregatedStatsInDetails: function(title, aggregatedStats) 913 showInDetails: function(title, node)
914 { 914 {
915 this._detailsView.setContent(title, WebInspector.TimelineUIUtils.generat ePieChart(aggregatedStats)); 915 this._detailsView.setContent(title, node);
916 }, 916 },
917 917
918 __proto__: WebInspector.Panel.prototype 918 __proto__: WebInspector.Panel.prototype
919 } 919 }
920 920
921 /** 921 /**
922 * @constructor 922 * @constructor
923 * @extends {WebInspector.VBox} 923 * @extends {WebInspector.VBox}
924 */ 924 */
925 WebInspector.TimelineDetailsView = function() 925 WebInspector.TimelineDetailsView = function()
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 */ 1019 */
1020 requestWindowTimes: function(startTime, endTime) {}, 1020 requestWindowTimes: function(startTime, endTime) {},
1021 1021
1022 /** 1022 /**
1023 * @param {?WebInspector.TimelineModel.Record} record 1023 * @param {?WebInspector.TimelineModel.Record} record
1024 */ 1024 */
1025 selectRecord: function(record) {}, 1025 selectRecord: function(record) {},
1026 1026
1027 /** 1027 /**
1028 * @param {string} title 1028 * @param {string} title
1029 * @param {!Object} aggregatedStats 1029 * @param {!Node} node
1030 */ 1030 */
1031 showAggregatedStatsInDetails: function(title, aggregatedStats) {}, 1031 showInDetails: function(title, node) {},
1032 } 1032 }
1033 1033
1034 /** 1034 /**
1035 * @constructor 1035 * @constructor
1036 * @extends {WebInspector.TimelineModel.Filter} 1036 * @extends {WebInspector.TimelineModel.Filter}
1037 */ 1037 */
1038 WebInspector.TimelineCategoryFilter = function() 1038 WebInspector.TimelineCategoryFilter = function()
1039 { 1039 {
1040 WebInspector.TimelineModel.Filter.call(this); 1040 WebInspector.TimelineModel.Filter.call(this);
1041 } 1041 }
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1156 * @param {!WebInspector.TimelineModel.Record} record 1156 * @param {!WebInspector.TimelineModel.Record} record
1157 * @return {boolean} 1157 * @return {boolean}
1158 */ 1158 */
1159 accept: function(record) 1159 accept: function(record)
1160 { 1160 {
1161 return !this._hiddenRecords[record.type]; 1161 return !this._hiddenRecords[record.type];
1162 }, 1162 },
1163 1163
1164 __proto__: WebInspector.TimelineModel.Filter.prototype 1164 __proto__: WebInspector.TimelineModel.Filter.prototype
1165 } 1165 }
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/TimelineView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698