Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2193623005: Roll PDFium 6f10254..3e454bf (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Oliver Chang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium 6f10254..3e454bf https://pdfium.googlesource.com/pdfium.git/+log/6f10254..3e454bf BUG=409472, 629839 TEST=bots TBR=ochang@chromium.org Committed: https://crrev.com/fe802a9564a41015714ddd7c0ff37bb870991dad Cr-Commit-Position: refs/heads/master@{#408862}

Patch Set 1 #

Patch Set 2 : Fix GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/pdfium.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Lei Zhang
TBR, more than just the DEPS file, but still trivial.
4 years, 4 months ago (2016-07-30 02:18:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193623005/20001
4 years, 4 months ago (2016-07-30 04:56:18 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 04:59:55 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fe802a9564a41015714ddd7c0ff37bb870991dad Cr-Commit-Position: refs/heads/master@{#408862}
4 years, 4 months ago (2016-07-30 05:04:19 UTC) #17
Oliver Chang
4 years, 4 months ago (2016-08-01 16:06:47 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698