Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2193623004: Revert of Enable RenderPassDrawQuad promotion to CALayer. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable RenderPassDrawQuad promotion to CALayer. (patchset #1 id:1 of https://codereview.chromium.org/2183333002/ ) Reason for revert: Has correctness problems: https://bugs.chromium.org/p/chromium/issues/detail?id=632613#c5 And likely performance problems: https://bugs.chromium.org/p/chromium/issues/detail?id=632636 Original issue's description: > Enable RenderPassDrawQuad promotion to CALayer. > > This CL enables the Core Animation compositor's implementation of CSS filter > effects. > > BUG=581526 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296 > Cr-Commit-Position: refs/heads/master@{#408216} TBR=ccameron@chromium.org,tandrii@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581526 Committed: https://crrev.com/bfdc4df9d2396016f8fa0b7d2070a998f343ca3e Cr-Commit-Position: refs/heads/master@{#408693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M cc/output/ca_layer_overlay.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/ca_layer_overlay.cc View 3 chunks +11 lines, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
Created Revert of Enable RenderPassDrawQuad promotion to CALayer.
4 years, 4 months ago (2016-07-29 17:30:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193623004/1
4 years, 4 months ago (2016-07-29 17:31:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 18:24:56 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 18:26:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfdc4df9d2396016f8fa0b7d2070a998f343ca3e
Cr-Commit-Position: refs/heads/master@{#408693}

Powered by Google App Engine
This is Rietveld 408576698