Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097
Committed: https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf
Cr-Commit-Position: refs/heads/master@{#409474}

[nyquist, 2016-07-28 22:58:56]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 22:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:41:04]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-07-29 20:34:16]

nyquist@chromium.org changed reviewers:
+ dtrainor@chromium.org

[nyquist, 2016-07-29 20:34:17]

dtrainor: PTAL

[David Trainor- moved to gerrit, 2016-08-02 22:53:27]

lgtm.  Just investigate the static to see if it's cleaner.  Both are unfortunate
and either works :).

https://codereview.chromium.org/2193623002/diff/1/blimp/client/core/android/b...
File blimp/client/core/android/blimp_client_context_impl_android.h (right):

https://codereview.chromium.org/2193623002/diff/1/blimp/client/core/android/b...
blimp/client/core/android/blimp_client_context_impl_android.h:27:
base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override;
Is this cleaner as a static?

[nyquist, 2016-08-03 01:57:11]

Description was changed from

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

There is one sad thing about this, which is that the
cross platform version of the class still has to have an implementation
of BlimpClientContext::GetJavaObject() to make it not be an abstract
class when compiled on Android.

BUG=611097
==========

to

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097
==========

[nyquist, 2016-08-03 01:58:30]

https://codereview.chromium.org/2193623002/diff/1/blimp/client/core/android/b...
File blimp/client/core/android/blimp_client_context_impl_android.h (right):

https://codereview.chromium.org/2193623002/diff/1/blimp/client/core/android/b...
blimp/client/core/android/blimp_client_context_impl_android.h:27:
base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override;
On 2016/08/02 22:53:27, David Trainor wrote:
> Is this cleaner as a static?

Yes it is! Cleaned up CL with this.

[nyquist, 2016-08-03 01:58:43]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-08-03 01:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2193623002/#ps40001
(title: "Convert to static method and fix dummy parts.")

[commit-bot: I haz the power, 2016-08-03 01:59:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 02:01:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 02:01:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nyquist, 2016-08-03 06:41:10]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-08-03 06:41:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2193623002/#ps60001
(title: "merge origin/master")

[commit-bot: I haz the power, 2016-08-03 06:41:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 07:25:12]

Description was changed from

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097
==========

to

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097
==========

[commit-bot: I haz the power, 2016-08-03 07:25:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-03 07:27:09]

Description was changed from

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097
==========

to

==========
Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG=611097

Committed: https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf
Cr-Commit-Position: refs/heads/master@{#409474}
==========

[commit-bot: I haz the power, 2016-08-03 07:27:10]

Patchset 4 (id:??) landed as
https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf
Cr-Commit-Position: refs/heads/master@{#409474}