ash/autoclick/common/BUILD.gn - Issue 2193563002: ash: Refactor autoclick common code to ash/autoclick/common.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/autoclick/common/BUILD.gn

Issue 2193563002: ash: Refactor autoclick common code to ash/autoclick/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/ui.gni")	5 import("//build/config/ui.gni")

6	6

7 component("touch_hud") {	7 component("autoclick") {
	sadrul 2016/07/29 20:13:35 Go with source_set instead of component Go with source_set instead of component riajiang 2016/08/04 16:51:20 Done. Show quoted text On 2016/07/29 20:13:35, sadrul wrote: > Go with source_set instead of component Done.
8 sources = [	8 sources = [

9 "ash_touch_hud_export.h",	9 "ash_autoclick_export.h",
	sadrul 2016/07/29 20:13:35 You don't need the export if you have it a source_ You don't need the export if you have it a source_set riajiang 2016/08/04 16:51:20 Done. Show quoted text On 2016/07/29 20:13:35, sadrul wrote: > You don't need the export if you have it a source_set Done.
10 "touch_hud_renderer.cc",	10 "autoclick_controller_common.cc",

11 "touch_hud_renderer.h",	11 "autoclick_controller_common.h",

	12 "autoclick_ring_handler.cc",

	13 "autoclick_ring_handler.h",

12 ]	14 ]

13	15

14 defines = [ "ASH_TOUCH_HUD_IMPLEMENTATION" ]	16 defines = [ "ASH_AUTOCLICK_IMPLEMENTATION" ]
	sadrul 2016/07/29 20:13:35 You won't need this either You won't need this either riajiang 2016/08/04 16:51:20 Done. Show quoted text On 2016/07/29 20:13:35, sadrul wrote: > You won't need this either Done.
15	17

16 deps = [	18 deps = [

17 "//base",	19 "//base",

18 "//skia",	20 "//skia",

	21 "//ui/aura",

19 "//ui/compositor",	22 "//ui/compositor",

20 "//ui/events",	23 "//ui/events",

21 "//ui/gfx",	24 "//ui/gfx",

22 "//ui/gfx/geometry",	25 "//ui/gfx/geometry",

23 "//ui/views",	26 "//ui/views",

	27 "//ui/wm",

24 ]	28 ]
	sadrul 2016/07/29 20:13:35 Add a DEPS file similar to the one in touch_hud to Add a DEPS file similar to the one in touch_hud to exclude all of ash. riajiang 2016/08/04 16:51:20 Done. Show quoted text On 2016/07/29 20:13:35, sadrul wrote: > Add a DEPS file similar to the one in touch_hud to exclude all of ash. Done.
25 }	29 }

OLD	NEW

« ash/autoclick/autoclick_controller.cc ('K') | « ash/autoclick/autoclick_controller.cc ('k') | ash/autoclick/common/ash_autoclick_export.h » ('j') | no next file with comments »