Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2193513002: GN: nanobench (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: nanobench Add nanobench, and while we're at it monobench to show off how cool source_sets are... the bench files are only built once then linked into both binaries. With GYP we build them twice. :/ Same deal for GMs between nanobench and DM... build once, link twice. nanobench uses SkImageEncoder to encode its .pngs, which requires we link in the image encoders, which requires we get them all in. That's the bulk of this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193513002 Committed: https://skia.googlesource.com/skia/+/2b6870ccb21f0dbcfb17644e9badfb1d07009315

Patch Set 1 #

Patch Set 2 : trim mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -25 lines) Patch
M BUILD.gn View 5 chunks +82 lines, -25 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 4 months ago (2016-07-28 20:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193513002/20001
4 years, 4 months ago (2016-07-28 20:36:17 UTC) #7
jcgregorio
lgtm
4 years, 4 months ago (2016-07-28 20:39:40 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:17:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2b6870ccb21f0dbcfb17644e9badfb1d07009315

Powered by Google App Engine
This is Rietveld 408576698