Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2193473002: Revert "Send got/lostpointercapture immediately if possible" (Closed)

Created:
4 years, 4 months ago by Navid Zolghadr
Modified:
4 years, 4 months ago
Reviewers:
dtapuska, lanwei, Rick Byers
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Send got/lostpointercapture immediately if possible" This reverts commit 7d314cf3ad6a9f0fe163228f7a0efc5a72adc560 as a follow up to the decision about delayed capturing https://github.com/w3c/pointerevents/issues/32 This also gets rid of the need to make PointerEventManager a GC object. BUG=627192, 629935 Committed: https://crrev.com/fbbdbf2f9d8b6ad09d8efba64b70d71563a25120 Cr-Commit-Position: refs/heads/master@{#408714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -123 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_mouse-manual-automation.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_is_first-manual-automation.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual-automation.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.h View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 10 chunks +18 lines, -90 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Navid Zolghadr
4 years, 4 months ago (2016-07-28 16:57:38 UTC) #5
Rick Byers
This is pretty much a direct revert, right (I've just given it a skim so ...
4 years, 4 months ago (2016-07-29 17:13:53 UTC) #10
Navid Zolghadr
On 2016/07/29 17:13:53, Rick Byers (slow until Aug 1) wrote: > This is pretty much ...
4 years, 4 months ago (2016-07-29 17:27:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193473002/1
4 years, 4 months ago (2016-07-29 17:27:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:19:48 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:22:35 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbbdbf2f9d8b6ad09d8efba64b70d71563a25120
Cr-Commit-Position: refs/heads/master@{#408714}

Powered by Google App Engine
This is Rietveld 408576698