Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2193433002: Revert of Update V8 to version 5.4.285. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.4.285. (patchset #1 id:1 of https://codereview.chromium.org/2187753004/ ) Reason for revert: I think this is causing compile failures on win x64: http://build.chromium.org/p/chromium/builders/Win%20x64/builds/2828 Original issue's description: > Update V8 to version 5.4.285. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/0b56cb99..41f6e072 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4 > Cr-Commit-Position: refs/heads/master@{#408392} TBR=hablich@chromium.org,littledan@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/75e2993f8a310d9f0f1969c6a818f59c94354fc4 Cr-Commit-Position: refs/heads/master@{#408405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Update V8 to version 5.4.285.
4 years, 4 months ago (2016-07-28 16:00:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193433002/1
4 years, 4 months ago (2016-07-28 16:00:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 16:01:09 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:02:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75e2993f8a310d9f0f1969c6a818f59c94354fc4
Cr-Commit-Position: refs/heads/master@{#408405}

Powered by Google App Engine
This is Rietveld 408576698