Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 219343003: Enable shrinksViewportContentToFit for Android (Closed)

Created:
6 years, 8 months ago by kenneth.r.christiansen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Enable shrinksViewportContentToFit for Android This behavior is now a setting, so enabled it for Android. Follow up to Blink side: 219223003. BUG=359047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
kenneth.r.christiansen
6 years, 8 months ago (2014-03-31 12:38:03 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 11:28:41 UTC) #2
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 15:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219343003/1
6 years, 8 months ago (2014-04-02 15:23:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 16:37:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=167171
6 years, 8 months ago (2014-04-02 16:37:38 UTC) #6
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 21:25:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219343003/1
6 years, 8 months ago (2014-04-02 21:28:17 UTC) #8
kenneth.r.christiansen
Moving this line outside the ifdef compiles fine locally. Could it be that it somehow ...
6 years, 8 months ago (2014-04-02 22:15:16 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 22:31:41 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=129260
6 years, 8 months ago (2014-04-02 22:31:41 UTC) #11
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-03 07:53:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219343003/1
6 years, 8 months ago (2014-04-03 07:55:29 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:05:08 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:05:08 UTC) #15
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-03 11:09:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219343003/1
6 years, 8 months ago (2014-04-03 11:09:32 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:19:39 UTC) #18
Message was sent while issue was closed.
Change committed as 261369

Powered by Google App Engine
This is Rietveld 408576698