Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2193403002: [ash-md] Disables rounded corners by default in overview mode (Closed)

Created:
4 years, 4 months ago by varkha
Modified:
4 years, 4 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Disables rounded corners by default in overview mode This CL only changes the default for the --ash-max-previews-to-use-mask runtime flag to 0 (from 10). Not using masks seems to improve animation. BUG=632825 TEST=None Committed: https://crrev.com/bf1dfd597226bb6cd8faf1009e8ba349a7e403aa Cr-Commit-Position: refs/heads/master@{#408748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/wm/overview/window_grid.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
varkha
tdanderson@, can you please take a look? This should be easy to merge into M-53 ...
4 years, 4 months ago (2016-07-29 20:06:55 UTC) #4
tdanderson
lgtm
4 years, 4 months ago (2016-07-29 20:27:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193403002/1
4 years, 4 months ago (2016-07-29 20:46:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:11:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:13:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf1dfd597226bb6cd8faf1009e8ba349a7e403aa
Cr-Commit-Position: refs/heads/master@{#408748}

Powered by Google App Engine
This is Rietveld 408576698