Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 2193393002: Revert of Linux: Support the --class argument (Closed)

Created:
4 years, 4 months ago by pavely
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng, sky, Elliot Glaysher, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux: Support the --class argument (patchset #4 id:60001 of https://codereview.chromium.org/2186813002/ ) Reason for revert: Change breaks compile on Linux x64: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12770 Original issue's description: > Linux: Support the --class argument > > It appears we lost support for --class when we stopped using gtk for our > windowing. This CL adds that feature back. > > BUG=118613 > > Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520 > Cr-Commit-Position: refs/heads/master@{#408709} TBR=thestig@chromium.org,benwells@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=118613 Committed: https://crrev.com/1019dd83f1b3c419a26ac681789e2d6da5d8e868 Cr-Commit-Position: refs/heads/master@{#408733}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -114 lines) Patch
M chrome/browser/shell_integration_linux.h View 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 2 chunks +5 lines, -55 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_util.cc View 1 chunk +1 line, -9 lines 1 comment Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.cc View 1 chunk +19 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pavely
Created Revert of Linux: Support the --class argument
4 years, 4 months ago (2016-07-29 19:55:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193393002/1
4 years, 4 months ago (2016-07-29 19:56:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:56:56 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1019dd83f1b3c419a26ac681789e2d6da5d8e868 Cr-Commit-Position: refs/heads/master@{#408733}
4 years, 4 months ago (2016-07-29 19:58:56 UTC) #6
Lei Zhang
4 years, 4 months ago (2016-07-29 20:37:23 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2193393002/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/gtk2_util.cc (left):

https://codereview.chromium.org/2193393002/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/gtk2_util.cc:64: version_info::Channel
product_channel(chrome::GetChannel());
IWYU @_@

Powered by Google App Engine
This is Rietveld 408576698