Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2193373002: Add rego and jfernandez to core/OWNERS after successful nomination (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
esprehn, eae
CC:
abarth-chromium, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add rego and jfernandez to core/OWNERS after successful nomination NOTRY=true Committed: https://crrev.com/62f1277d0166ae7eabb84dfa27218c65ea69b4ad Cr-Commit-Position: refs/heads/master@{#408752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/OWNERS View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
cbiesinger
4 years, 4 months ago (2016-07-29 19:37:57 UTC) #1
esprehn
lgtm
4 years, 4 months ago (2016-07-29 20:27:32 UTC) #3
esprehn
On 2016/07/29 at 20:27:32, esprehn wrote: > lgtm They each have over 100 commits since ...
4 years, 4 months ago (2016-07-29 20:28:01 UTC) #4
cbiesinger
Rego has 139 Javier has 79 Is 100+ a requirement? The blink-core-owners thread did not ...
4 years, 4 months ago (2016-07-29 20:44:33 UTC) #5
esprehn
On 2016/07/29 at 20:44:33, cbiesinger wrote: > Rego has 139 > Javier has 79 > ...
4 years, 4 months ago (2016-07-29 20:48:41 UTC) #6
cbiesinger
On 2016/07/29 20:48:41, esprehn wrote: > On 2016/07/29 at 20:44:33, cbiesinger wrote: > > Rego ...
4 years, 4 months ago (2016-07-29 20:49:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193373002/1
4 years, 4 months ago (2016-07-29 21:07:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:14:39 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62f1277d0166ae7eabb84dfa27218c65ea69b4ad Cr-Commit-Position: refs/heads/master@{#408752}
4 years, 4 months ago (2016-07-29 21:18:03 UTC) #14
eae
4 years, 4 months ago (2016-08-01 16:11:16 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698